Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] kms_flip: Add -lrt back
@ 2012-12-18 14:51 ville.syrjala
  2012-12-18 15:04 ` Daniel Vetter
  0 siblings, 1 reply; 2+ messages in thread
From: ville.syrjala @ 2012-12-18 14:51 UTC (permalink / raw)
  To: intel-gfx

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

kms_flip doesn't build due to missing -lrt.

The build was broken due to a typo in this commit:

commit acdf7171264a5139caabb78127c9eef5080c0682
Author: Daniel Vetter <daniel.vetter@ffwll.ch>
Date:   Sat Dec 15 00:48:47 2012 +0100

    tests: s/flip_test/kms_flip

    OCD wins!

    Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

For some reason libudev.pc brings in -lrt as well, which probably
caused the typo to go unnoticed.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 tests/Makefile.am |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tests/Makefile.am b/tests/Makefile.am
index 9cafe4c..0476908 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -180,7 +180,7 @@ gem_fence_thrash_LDADD = $(LDADD) -lpthread
 gem_threaded_access_tiled_LDADD = $(LDADD) -lpthread
 
 gem_wait_render_timeout_LDADD = $(LDADD) -lrt
-kms_flip = $(LDADD) -lrt
+kms_flip_LDADD = $(LDADD) -lrt
 
 gem_ctx_basic_LDADD = $(LDADD) -lpthread
 
-- 
1.7.8.6

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] kms_flip: Add -lrt back
  2012-12-18 14:51 [PATCH] kms_flip: Add -lrt back ville.syrjala
@ 2012-12-18 15:04 ` Daniel Vetter
  0 siblings, 0 replies; 2+ messages in thread
From: Daniel Vetter @ 2012-12-18 15:04 UTC (permalink / raw)
  To: ville.syrjala; +Cc: intel-gfx

On Tue, Dec 18, 2012 at 04:51:27PM +0200, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> kms_flip doesn't build due to missing -lrt.
> 
> The build was broken due to a typo in this commit:
> 
> commit acdf7171264a5139caabb78127c9eef5080c0682
> Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> Date:   Sat Dec 15 00:48:47 2012 +0100
> 
>     tests: s/flip_test/kms_flip
> 
>     OCD wins!
> 
>     Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> 
> For some reason libudev.pc brings in -lrt as well, which probably
> caused the typo to go unnoticed.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Blargh, I suck, thanks for fixing this up.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-12-18 15:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-18 14:51 [PATCH] kms_flip: Add -lrt back ville.syrjala
2012-12-18 15:04 ` Daniel Vetter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox