From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Reject out-of-bound sprites
Date: Tue, 8 Jan 2013 17:56:43 +0100 [thread overview]
Message-ID: <20130108165643.GC5737@phenom.ffwll.local> (raw)
In-Reply-To: <20130108111138.GY5737@phenom.ffwll.local>
On Tue, Jan 08, 2013 at 12:11:38PM +0100, Daniel Vetter wrote:
> On Tue, Dec 18, 2012 at 10:18:28PM +0000, Chris Wilson wrote:
> > We make no attempt to fixup the source as we adjust the destination
> > rectangle, expect the caller to have already fixed that up. This makes
> > no sense, asking userspace to compensate for the kernel adjusting the
> > one rectangle not the other, so simply reject any attempt to show an
> > partially visible box. Userspace should know better.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>
> I guess this makes sense for now, given that the only user we have (ddx)
> needs to copy things around anyway ... Still, some common users and
> testcases across drivers would be nice for this </wishful-thinking>.
>
> Applied to fixes.
Dropped again, since Ville has a more complete solution to this in his
queue.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2013-01-08 16:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-18 22:18 [PATCH] drm/i915: Reject out-of-bound sprites Chris Wilson
2013-01-08 11:11 ` Daniel Vetter
2013-01-08 16:56 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130108165643.GC5737@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox