From: Daniel Vetter <daniel@ffwll.ch>
To: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/1] tests/gem_ctx_exec: fix destroy ioctl number
Date: Mon, 4 Feb 2013 17:27:25 +0100 [thread overview]
Message-ID: <20130204162725.GG5843@phenom.ffwll.local> (raw)
In-Reply-To: <1359983610-10621-1-git-send-email-mika.kuoppala@intel.com>
On Mon, Feb 04, 2013 at 03:13:30PM +0200, Mika Kuoppala wrote:
> Destroy was never called properly
>
> Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
Oops, that's a bit a goof-up, nice catch. While at it, can you please
augment the test to check whether a destroyed context doesn't work any
more for batchbuffers? It looks like gem_ctx_exec.c should be easy to
extend with this.
-Daniel
> ---
> tests/gem_ctx_exec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/gem_ctx_exec.c b/tests/gem_ctx_exec.c
> index 423f1ee..0288fe8 100644
> --- a/tests/gem_ctx_exec.c
> +++ b/tests/gem_ctx_exec.c
> @@ -57,7 +57,7 @@ struct local_drm_i915_gem_context_destroy {
> };
>
> #define CONTEXT_CREATE_IOCTL DRM_IOWR(DRM_COMMAND_BASE + 0x2d, struct local_drm_i915_gem_context_create)
> -#define CONTEXT_DESTROY_IOCTL DRM_IOWR(DRM_COMMAND_BASE + 0x23, struct local_drm_i915_gem_context_destroy)
> +#define CONTEXT_DESTROY_IOCTL DRM_IOWR(DRM_COMMAND_BASE + 0x2e, struct local_drm_i915_gem_context_destroy)
>
> static uint32_t context_create(int fd)
> {
> --
> 1.7.9.5
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2013-02-04 16:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-04 13:13 [PATCH 1/1] tests/gem_ctx_exec: fix destroy ioctl number Mika Kuoppala
2013-02-04 16:27 ` Daniel Vetter [this message]
2013-02-05 10:26 ` [PATCH] tests/gem_ctx_exec: properly test destroy_ctx ioctl Mika Kuoppala
2013-02-05 11:06 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130204162725.GG5843@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kuoppala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox