From: Daniel Vetter <daniel@ffwll.ch>
To: Ben Widawsky <ben@bwidawsk.net>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Fix gen2 mappable calculations
Date: Sun, 10 Feb 2013 00:03:01 +0100 [thread overview]
Message-ID: <20130209230301.GZ5813@phenom.ffwll.local> (raw)
In-Reply-To: <1360351967-1011-1-git-send-email-ben@bwidawsk.net>
On Fri, Feb 08, 2013 at 11:32:47AM -0800, Ben Widawsky wrote:
> When I refactored the code initially, I forgot that gen2 uses a
> different bar for the CPU mappable aperture. The agp-less code knows
> nothing of generations less than 5, so we have to expand the gtt_probe
> function to include the mappable base and end.
>
> It was originally broken by me:
> commit baa09f5fd8a6d033ec075355dda99a65b7f6a0f3
> Author: Ben Widawsky <ben@bwidawsk.net>
> Date: Thu Jan 24 13:49:57 2013 -0800
>
> drm/i915: Add probe and remove to the gtt ops
>
> Reported-by: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
Queued for -next, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2013-02-09 23:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-08 19:32 [PATCH] drm/i915: Fix gen2 mappable calculations Ben Widawsky
2013-02-09 23:03 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130209230301.GZ5813@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox