From: Daniel Vetter <daniel@ffwll.ch>
To: Ben Widawsky <ben@bwidawsk.net>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v3] drm/i915: Extract ring init from hw_init
Date: Sun, 10 Feb 2013 00:07:04 +0100 [thread overview]
Message-ID: <20130209230704.GA5813@phenom.ffwll.local> (raw)
In-Reply-To: <1360352964-8169-1-git-send-email-ben@bwidawsk.net>
On Fri, Feb 08, 2013 at 11:49:24AM -0800, Ben Widawsky wrote:
> The ring initialization will differ a bit in upcoming generations, and
> this split will prepare the code for what's needed.
>
> This patch also fixes a bug introduced in:
> commit 99433931950f33039d9e1a52b4ed9af3f1b58e84
> Author: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> Date: Tue Jan 22 14:12:17 2013 +0200
>
> drm/i915: use gem_set_seqno() on hardware init
>
> After doing the extraction, the bad error handling became obvious. I
> acknowledge that this should be two patches, but it's a pretty
> small/trivial patch. If requested, I can certainly do the fix as a
> distinct patch.
>
> v2: Should be cleanup blt, not init blt on failure (Chris)
>
> v3: Forgot to git add on v2
>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
Queued for -next, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2013-02-09 23:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-08 18:17 [PATCH] drm/i915: Extract ring init from hw_init Ben Widawsky
2013-02-08 19:42 ` [PATCH v2] " Ben Widawsky
2013-02-08 19:49 ` [PATCH v3] " Ben Widawsky
2013-02-09 23:07 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130209230704.GA5813@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox