From: Daniel Vetter <daniel@ffwll.ch>
To: ville.syrjala@linux.intel.com
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2 2/2] drm/i915: Fix races in gen4 page flip interrupt handling
Date: Wed, 20 Feb 2013 15:38:08 +0100 [thread overview]
Message-ID: <20130220143808.GE5813@phenom.ffwll.local> (raw)
In-Reply-To: <1361279799-16582-3-git-send-email-ville.syrjala@linux.intel.com>
On Tue, Feb 19, 2013 at 03:16:39PM +0200, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Use the gen3 logic for handling page flip interrupts on gen4.
>
> Unfortuantely this kills the stall_check since that looks like it can
> easily trigger too early. With the current logic the stall check would
> kick in on the first vblank after the flip has been submitted to the
> ring. If the CS takes longer than that to process the commands in the
> ring, the stall check will cause the page flip to be complete too
> early. That doesn't sound like a very good idea. Something better
> should be deviced if we still need the stall check. For now, mark
> i915_pageflip_stall_check() as unused.
>
> v2: Fix irq enable_mask and add __always_unused (Chris Wilson)
>
> References: https://bugs.launchpad.net/ubuntu/+source/xserver-xorg-video-intel/+bug/1116587
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> Tested-by: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Both merge to dinq, thanks.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2013-02-20 14:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-19 13:16 [PATCH 0/2] drm/i915: gen2-4 page flip fixes ville.syrjala
2013-02-19 13:16 ` [PATCH v3 1/2] drm/i915: Eliminate race from gen2/3 page flip interrupt handling ville.syrjala
2013-02-19 19:19 ` Daniel Vetter
2013-02-19 13:16 ` [PATCH v2 2/2] drm/i915: Fix races in gen4 " ville.syrjala
2013-02-20 14:38 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130220143808.GE5813@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox