Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Keng-Yu Lin <kengyu@canonical.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] display: change the priority order of intel_backlight
Date: Sun, 3 Mar 2013 18:34:55 +0100	[thread overview]
Message-ID: <20130303173455.GJ9021@phenom.ffwll.local> (raw)
In-Reply-To: <1361866600-29971-1-git-send-email-kengyu@canonical.com>

On Tue, Feb 26, 2013 at 04:16:40PM +0800, Keng-Yu Lin wrote:
> make the intel_backlight interface with a higher priority
> than acpi_video, as it is more likely to work.
> 
> Signed-off-by: Keng-Yu Lin <kengyu@canonical.com>

If you have a non-working acpi backlight, that's a bug in the kernel's
acpi subsystem. Most likely it needs to be blacklisted.
-Daniel

> ---
>  src/intel_display.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/intel_display.c b/src/intel_display.c
> index 5ee955e..479afb7 100644
> --- a/src/intel_display.c
> +++ b/src/intel_display.c
> @@ -142,9 +142,9 @@ static const char *backlight_interfaces[] = {
>  	"fujitsu-laptop",
>  	"sony",
>  	"samsung",
> +	"intel_backlight",
>  	"acpi_video1", /* finally fallback to the generic acpi drivers */
>  	"acpi_video0",
> -	"intel_backlight",
>  	NULL,
>  };
>  /*
> -- 
> 1.7.9.5
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

      parent reply	other threads:[~2013-03-03 17:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-26  8:16 [PATCH] display: change the priority order of intel_backlight Keng-Yu Lin
2013-03-03 17:34 ` Chris Wilson
2013-03-03 17:34 ` Daniel Vetter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130303173455.GJ9021@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=kengyu@canonical.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox