[PATCH] display: change the priority order of intel_backlight

[PATCH] display: change the priority order of intel_backlight

[Keng-Yu Lin]

make the intel_backlight interface with a higher priority
than acpi_video, as it is more likely to work.

Signed-off-by: Keng-Yu Lin <kengyu@canonical.com>
---
 src/intel_display.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/intel_display.c b/src/intel_display.c
index 5ee955e..479afb7 100644
--- a/src/intel_display.c
+++ b/src/intel_display.c
@@ -142,9 +142,9 @@ static const char *backlight_interfaces[] = {
 	"fujitsu-laptop",
 	"sony",
 	"samsung",
+	"intel_backlight",
 	"acpi_video1", /* finally fallback to the generic acpi drivers */
 	"acpi_video0",
-	"intel_backlight",
 	NULL,
 };
 /*
-- 
1.7.9.5

Re: [PATCH] display: change the priority order of intel_backlight

[Chris Wilson]

On Tue, Feb 26, 2013 at 04:16:40PM +0800, Keng-Yu Lin wrote:
> make the intel_backlight interface with a higher priority
> than acpi_video, as it is more likely to work.

It is not, and the priority is explicitly lower than firmware (which
itself is lower than platform).
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

Re: [PATCH] display: change the priority order of intel_backlight

[Daniel Vetter]

On Tue, Feb 26, 2013 at 04:16:40PM +0800, Keng-Yu Lin wrote:
> make the intel_backlight interface with a higher priority
> than acpi_video, as it is more likely to work.
> 
> Signed-off-by: Keng-Yu Lin <kengyu@canonical.com>

If you have a non-working acpi backlight, that's a bug in the kernel's
acpi subsystem. Most likely it needs to be blacklisted.
-Daniel

> ---
>  src/intel_display.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/intel_display.c b/src/intel_display.c
> index 5ee955e..479afb7 100644
> --- a/src/intel_display.c
> +++ b/src/intel_display.c
> @@ -142,9 +142,9 @@ static const char *backlight_interfaces[] = {
>  	"fujitsu-laptop",
>  	"sony",
>  	"samsung",
> +	"intel_backlight",
>  	"acpi_video1", /* finally fallback to the generic acpi drivers */
>  	"acpi_video0",
> -	"intel_backlight",
>  	NULL,
>  };
>  /*
> -- 
> 1.7.9.5
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch