Re: [PATCH] assembler: Add a regions visualizer tool

[Damien Lespiau <damien.lespiau@intel.com>]

On Tue, Mar 12, 2013 at 05:53:01PM +0000, Chris Cummins wrote:
> This adds a html/js tool for visualizing GEN instruction source operand
> regions, similar to those used in the Programmer's Reference Manual. To
> use the tool, open the file assembler/gen_regions/gen_regions.html in
> your browser-of-preference.

To give more details about that work, there's nothing better than
examples, visualizing regions taken directly from the published IVB
documentation:

http://damien.lespiau.name/intel/gen_regions.html#execsize=16&region=g4.2<16;8,2>w&advanced=0

http://damien.lespiau.name/intel/gen_regions.html#execsize=16&region=r5.0<1;8,2>:w&advanced=0

A quick review trying to use the tool:

  * I think it'd be better if byte 0 is at the right, it seems to be the
    usual ways to represent registers, lower bits at the right.
  * there's a bug when giving advanced=1 on the URL, the tool doesn't
    seem to take it into account
  * it'd be nice to get rid of the trailing white space (no review would
    be complete without a mention to trailing white space, rule #1 of
    the open source world) from the imported js files, I usually use a
    script around:
    	sed -i -e 's,[ \t]*$,,' $file

-- 
Damien