From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Fix pipe enabled mask for pipe C in WM calculations
Date: Wed, 20 Mar 2013 15:50:06 -0700 [thread overview]
Message-ID: <20130320155006.5427638e@jbarnes-desktop> (raw)
In-Reply-To: <20130320223933.GA7131@cantiga.alporthouse.com>
On Wed, 20 Mar 2013 22:39:33 +0000
Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Wed, Mar 20, 2013 at 11:05:37PM +0100, Daniel Vetter wrote:
> > On Wed, Mar 20, 2013 at 09:51:05PM +0200, ville.syrjala@linux.intel.com wrote:
> > > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > >
> > > Cc: stable@vger.kernel.org
> >
> > One of the stable rules is that patches should fix real issues. So can you
> > please hunt through bugzillas quickly and feed this to relevant bug
> > reports?
>
> It would take an astute user to notice that his machine was not using a
> lower power self-refresh FIFO mode. And the number of machines that only
> set up the third pipe is going to be small, so the impact minor. It
> will not fix any of the three pipe issues we have open, for example.
>
> The patch is correct, though had I used enabled |= 1 << PIPE_[ABC] it
> would have probably prevented this bug.
>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
My fault; I had to merge the initial 3 pipe code after Chris changed
this and added the enabled bitfield. I remember complaining about it
at the time, I must have been feeling passive-aggressive and snuck the
bug in. :)
--
Jesse Barnes, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2013-03-20 22:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-20 19:51 [PATCH] drm/i915: Fix pipe enabled mask for pipe C in WM calculations ville.syrjala
2013-03-20 22:05 ` [Intel-gfx] " Daniel Vetter
2013-03-20 22:39 ` Chris Wilson
2013-03-20 22:49 ` Daniel Vetter
2013-03-20 22:50 ` Jesse Barnes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130320155006.5427638e@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox