From: Daniel Vetter <daniel@ffwll.ch>
To: Paulo Zanoni <przanoni@gmail.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2] drm/i915: Warn if a pipe is enabled with a bogus port
Date: Mon, 25 Mar 2013 19:21:19 +0100 [thread overview]
Message-ID: <20130325182119.GM9021@phenom.ffwll.local> (raw)
In-Reply-To: <CA+gsUGSsKCYWt5c_0Z9NbyxFMTvE5SexOfrRH1oE=ZUoTX-qjQ@mail.gmail.com>
On Mon, Mar 25, 2013 at 02:00:16PM -0300, Paulo Zanoni wrote:
> Hi
>
> 2013/3/25 Damien Lespiau <damien.lespiau@intel.com>:
> > If TRANS_DDI_FUNC_CTL has been wrongly programmed with an incorrect
> > port, we are currently trying to read PORT_CLK_SEL(port) with an
> > uninitialized value.
> >
> > Handle that case by returning PORT_CLK_SEL_NONE and warning about it.
> >
> > v2: Move the warning inside intel_ddi_get_crtc_pll (Paulo Zanoni)
> >
> > Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
>
> Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Queued for -next, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2013-03-25 18:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-07 15:30 [PATCH 1/6] drm/i915: Warn if a pipe is enabled with a bogus port Damien Lespiau
2013-03-07 15:30 ` [PATCH 2/6] drm/i915: Initialize wait in intel_ddi_prepare_link_retrain() Damien Lespiau
2013-03-08 21:03 ` Ben Widawsky
2013-03-07 15:30 ` [PATCH 3/6] drm/i915: Error out if we are trying to use VGA with SPLL already in use Damien Lespiau
2013-03-08 21:06 ` Ben Widawsky
2013-03-22 21:14 ` Paulo Zanoni
2013-03-23 12:27 ` Daniel Vetter
2013-03-07 15:30 ` [PATCH 4/6] drm/i915: Cleanup if the EDP transcoder has a bobug input value Damien Lespiau
2013-03-22 21:34 ` Paulo Zanoni
2013-03-23 12:30 ` Daniel Vetter
2013-03-07 15:30 ` [PATCH 5/6] drm/i915: Rename intel_ddi_enable_pipe_func() to transcoder_func() Damien Lespiau
2013-03-22 21:37 ` Paulo Zanoni
2013-03-07 15:30 ` [PATCH 6/6] drm/i915: Use BUG() in a case of a programming error Damien Lespiau
2013-03-22 21:43 ` Paulo Zanoni
2013-03-23 12:31 ` Daniel Vetter
2013-03-22 21:04 ` [PATCH 1/6] drm/i915: Warn if a pipe is enabled with a bogus port Paulo Zanoni
2013-03-25 15:16 ` [PATCH v2] " Damien Lespiau
2013-03-25 17:00 ` Paulo Zanoni
2013-03-25 18:21 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130325182119.GM9021@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=przanoni@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox