Re: [PATCH 03/13] drm/i915: add pipe_config->timings_set

[Jesse Barnes <jbarnes@virtuousgeek.org>]

On Wed, 27 Mar 2013 18:06:44 +0100
Daniel Vetter <daniel.vetter@ffwll.ch> wrote:

> On Wed, Mar 27, 2013 at 5:59 PM, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> >> @@ -203,6 +201,10 @@ struct intel_connector {
> >>  struct intel_crtc_config {
> >>       struct drm_display_mode requested_mode;
> >>       struct drm_display_mode adjusted_mode;
> >> +     /* This flag must be set by the encoder's compute_config callback if it
> >> +      * changes the crtc timings in the mode to prevent the crtc fixup from
> >> +      * overwriting them.  Currently only lvds needs that. */
> >> +     bool timings_set;
> >
> > The compute_config function could actually use some kdoc instead of
> > putting it over the timings_set function.  It'll need to be expanded to
> > cover all the pipe_config bits eventually, what they mean and when they
> > should be set.
> 
> Now I very much like to claim the opposite, but this isn't designed
> but very much organically grown code. So imo documentation doesn't
> make too much sense before things settle a bit more (the auto fdi link
> dither at the end will introduce quite a bit of fun still ...).
> 
> I've promised though in my pipe_config intro a few weeks ago that I'll
> create a nice blog post and doc patch once the basic stuff is settled.
> I still intend to deliver on that. Is that good enough?

I guess so... incrementally adding to the compute_config kdoc with the
new pipe_config bits as added is too much rebase pain?

-- 
Jesse Barnes, Intel Open Source Technology Center