From: Chris Wilson <chris@chris-wilson.co.uk>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: s/mdelay/msleep/
Date: Mon, 8 Apr 2013 11:03:41 +0100 [thread overview]
Message-ID: <20130408100341.GD3792@cantiga.alporthouse.com> (raw)
In-Reply-To: <1365325983-13033-1-git-send-email-daniel.vetter@ffwll.ch>
On Sun, Apr 07, 2013 at 11:13:03AM +0200, Daniel Vetter wrote:
> The first in wait_pipe_off is really just a delay loop to wait for the
> scanline counter to settle (which takes about a frame worth of time).
> So also shrink it a bit.
>
> The other is in the ilk dprs code. If we need _exactly_ an 1ms wait in
> there, that's already not guaranteed with the current code (since
> especially at start-up we're likely to get scheduled away in between).
> So replace those, too.
>
> Noticed while trying to understand why we've again broken the panel
> fitter.
>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
The only reason the mdelay(5) persisted for so long was that we were
being lazy and not verifying that path could not be called from atomic
context.
The others I just credit Jesse for.
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2013-04-08 10:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-07 9:13 [PATCH] drm/i915: s/mdelay/msleep/ Daniel Vetter
2013-04-08 10:03 ` Chris Wilson [this message]
2013-04-08 11:49 ` Paulo Zanoni
2013-04-08 11:56 ` Daniel Vetter
2013-04-08 15:30 ` Jesse Barnes
-- strict thread matches above, loose matches on Subject: below --
2015-07-07 7:10 Daniel Vetter
2015-07-07 8:03 ` Ville Syrjälä
2015-07-07 9:44 ` Daniel Vetter
2015-07-08 5:54 ` shuang.he
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130408100341.GD3792@cantiga.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox