From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Paulo Zanoni <przanoni@gmail.com>,
intel-gfx@lists.freedesktop.org,
Paulo Zanoni <paulo.r.zanoni@intel.com>,
stable@vger.kernel.org
Subject: Re: [Intel-gfx] [PATCH 2/3] drm/i915: don't intel_crt_init on any ULT machines
Date: Tue, 16 Apr 2013 10:35:41 +0200 [thread overview]
Message-ID: <20130416083541.GG27612@phenom.ffwll.local> (raw)
In-Reply-To: <20130415204500.GB4106@cantiga.alporthouse.com>
On Mon, Apr 15, 2013 at 09:45:00PM +0100, Chris Wilson wrote:
> On Fri, Apr 12, 2013 at 06:16:53PM -0300, Paulo Zanoni wrote:
> > From: Paulo Zanoni <paulo.r.zanoni@intel.com>
> >
> > We may have DDI_BUF_CTL(PORT_A) configured with 2 lanes and still not
> > have CRT, so just check for !IS_ULT. This problem happened on a real
> > machine and resulted in a very ugly dmesg.
> >
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
>
> This doesn't apply to dinq. The approach I'd favour is to have a
> intel_info.has_crt similar to the other feature flags.
I'm ok with piling checks on top here for now, I guess we should
reconsider once the next hw platforms shows up around the corner ...
All patches merged to dinq, thanks.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2013-04-16 8:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-12 21:16 [PATCH 1/3] drm/i915: remove comment about IVB link training from intel_pm.c Paulo Zanoni
2013-04-12 21:16 ` [PATCH 2/3] drm/i915: don't intel_crt_init on any ULT machines Paulo Zanoni
2013-04-15 20:45 ` [Intel-gfx] " Chris Wilson
2013-04-16 8:35 ` Daniel Vetter [this message]
2013-04-16 13:41 ` Paulo Zanoni
2013-04-16 17:10 ` Daniel Vetter
2013-04-12 21:16 ` [PATCH 3/3] drm/i915: WARN when LPT-LP is not paired with ULT CPU Paulo Zanoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130416083541.GG27612@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
--cc=przanoni@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox