From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 05/15] drm/i915: implement high-bpc + pipeconf-dither support for g4x/vlv
Date: Fri, 19 Apr 2013 09:39:11 -0700 [thread overview]
Message-ID: <20130419093911.4b4e72dc@jbarnes-desktop> (raw)
In-Reply-To: <1366363487-15926-6-git-send-email-daniel.vetter@ffwll.ch>
On Fri, 19 Apr 2013 11:24:37 +0200
Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> + pipeconf &= ~(PIPECONF_BPC_MASK | PIPECONF_DITHER_EN);
> + if (intel_crtc->config.dither && intel_crtc->config.pipe_bpp != 30)
I think the magic != 30 check needs a comment, or we should never
set .dither for 30bpp modes in the various compute_configs.
--
Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2013-04-19 16:38 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-19 9:24 [PATCH 00/15] high-bpp fixes and fdi auto dithering Daniel Vetter
2013-04-19 9:24 ` [PATCH 01/15] drm/i915: fixup 12bpc hdmi dotclock handling Daniel Vetter
2013-04-23 15:02 ` Ville Syrjälä
2013-04-23 15:37 ` Daniel Vetter
2013-04-19 9:24 ` [PATCH 02/15] drm/i915: Disable high-bpc on pre-1.4 EDID screens Daniel Vetter
2013-04-23 15:07 ` Ville Syrjälä
2013-04-24 10:54 ` Daniel Vetter
2013-04-19 9:24 ` [PATCH 03/15] drm/i915: force bpp for eDP panels Daniel Vetter
2013-04-19 20:31 ` [PATCH] " Daniel Vetter
2013-04-19 9:24 ` [PATCH 04/15] drm/i915: drop adjusted_mode from *_set_pipeconf functions Daniel Vetter
2013-04-23 15:12 ` Ville Syrjälä
2013-04-19 9:24 ` [PATCH 05/15] drm/i915: implement high-bpc + pipeconf-dither support for g4x/vlv Daniel Vetter
2013-04-19 16:39 ` Jesse Barnes [this message]
2013-04-19 18:17 ` [PATCH] " Daniel Vetter
2013-04-19 18:39 ` Jesse Barnes
2013-04-19 19:29 ` Daniel Vetter
2013-04-23 15:27 ` Ville Syrjälä
2013-04-23 20:39 ` Daniel Vetter
2013-04-23 22:27 ` Daniel Vetter
2013-04-24 11:07 ` Ville Syrjälä
2013-04-23 22:30 ` Daniel Vetter
2013-04-24 11:11 ` Ville Syrjälä
2013-04-24 12:57 ` Daniel Vetter
2013-04-24 13:07 ` Ville Syrjälä
2013-04-19 9:24 ` [PATCH 06/15] drm/i915: allow high-bpc modes on DP Daniel Vetter
2013-04-29 10:16 ` Imre Deak
2013-04-19 9:24 ` [PATCH 07/15] drm/i915: Fixup non-24bpp support for VGA screens on Haswell Daniel Vetter
2013-04-24 11:12 ` Ville Syrjälä
2013-04-24 12:50 ` Daniel Vetter
2013-04-19 9:24 ` [PATCH 08/15] drm/i915: move intel_crtc->fdi_lanes to pipe_config Daniel Vetter
2013-04-29 10:17 ` Imre Deak
2013-04-19 9:24 ` [PATCH 09/15] drm/i915: hw state readout support for pipe_config->fdi_lanes Daniel Vetter
2013-04-24 11:23 ` Ville Syrjälä
2013-04-24 12:49 ` Daniel Vetter
2013-04-24 13:30 ` [PATCH] " Daniel Vetter
2013-04-29 10:22 ` Imre Deak
2013-04-29 17:33 ` [PATCH] drm/i915: put the right cpu_transcoder into pipe_config for hw state readout Daniel Vetter
2013-04-29 17:33 ` [PATCH] drm/i915: hw state readout support for pipe_config->fdi_lanes Daniel Vetter
2013-04-19 9:24 ` [PATCH 10/15] drm/i915: split up fdi_set_m_n into computation and hw setup Daniel Vetter
2013-04-24 11:26 ` Ville Syrjälä
2013-04-19 9:24 ` [PATCH 11/15] drm/i915: compute fdi lane config earlier Daniel Vetter
2013-04-29 12:13 ` Imre Deak
2013-04-19 9:24 ` [PATCH 12/15] drm/i915: Split up ironlake_check_fdi_lanes Daniel Vetter
2013-04-29 12:19 ` Imre Deak
2013-04-19 9:24 ` [PATCH 13/15] drm/i915: move fdi lane configuration checks ahead Daniel Vetter
2013-04-22 10:32 ` Ville Syrjälä
2013-04-22 15:13 ` [PATCH] " Daniel Vetter
2013-04-29 12:31 ` Imre Deak
2013-04-29 17:34 ` Daniel Vetter
2013-04-19 9:24 ` [PATCH 14/15] drm/i915: don't count cpu ports for fdi B/C lane sharing Daniel Vetter
2013-04-29 13:00 ` Imre Deak
2013-04-19 9:24 ` [PATCH 15/15] drm/i915: implement fdi auto-dithering Daniel Vetter
2013-04-29 14:02 ` Imre Deak
2013-04-29 14:43 ` Daniel Vetter
2013-04-29 14:59 ` Imre Deak
2013-04-29 19:35 ` Daniel Vetter
2013-04-19 15:05 ` [PATCH 00/15] high-bpp fixes and fdi auto dithering Chris Wilson
2013-04-25 10:28 ` Jani Nikula
2013-04-29 19:51 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130419093911.4b4e72dc@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox