From: Chris Wilson <chris@chris-wilson.co.uk>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Jani Nikula <jani.nikula@intel.com>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: disable interrupts earlier in the driver unload code
Date: Wed, 24 Apr 2013 10:35:16 +0100 [thread overview]
Message-ID: <20130424093516.GC11689@cantiga.alporthouse.com> (raw)
In-Reply-To: <1366795160-2427-1-git-send-email-daniel.vetter@ffwll.ch>
On Wed, Apr 24, 2013 at 11:19:20AM +0200, Daniel Vetter wrote:
> Our rps code relies on the interrupts being off to prevent re-arming
> of the work items at inopportune moments.
>
> Also drop the redundant cancel_work for the main rps work,
> disable_gt_powersave already takes care of that.
>
> Finally add a WARN_ON to ensure we obey that piece of ordering
> constraint. Long term I want to lock down the setup/teardown code in a
> similar way to how we painstakingly check modeset sequence constraints
> already.
Reminds me, did we every get around to flushing our deferred hw tasks
upon suspend? I've a funny feeling that is still missing.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2013-04-24 9:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-24 9:19 [PATCH] drm/i915: disable interrupts earlier in the driver unload code Daniel Vetter
2013-04-24 9:35 ` Chris Wilson [this message]
2013-04-24 9:51 ` Daniel Vetter
2013-04-24 10:08 ` Jani Nikula
2013-04-24 10:21 ` Daniel Vetter
2013-04-24 10:58 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130424093516.GC11689@cantiga.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox