From: Daniel Vetter <daniel@ffwll.ch>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915: factor out GMCH panel fitting code and use for eDP v2
Date: Wed, 24 Apr 2013 18:56:32 +0200 [thread overview]
Message-ID: <20130424165632.GX6169@phenom.ffwll.local> (raw)
In-Reply-To: <20130424082921.343fbbab@jbarnes-desktop>
On Wed, Apr 24, 2013 at 08:29:21AM -0700, Jesse Barnes wrote:
> On Wed, 24 Apr 2013 18:05:54 +0300
> Mika Kuoppala <mika.kuoppala@linux.intel.com> wrote:
>
> > This is different than it was in lvds_compute_config. If we get called
> > with DRM_MODE_SCALE_NONE we go to fullscreen instead.
> > Is this intentional?
>
> Yeah, figured I'd make it identical to the eDP case. But we could
> change that one instead if you have a preference.
SCALE_NONE is rejected in both lvds and edp output's set_property. So not
relevant. Maybe we should smash a WARN into the default case instead?
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2013-04-24 16:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-18 23:05 [PATCH 1/2] drm/i915: factor out GMCH panel fitting code and use for eDP v2 Jesse Barnes
2013-04-18 23:05 ` [PATCH 2/2] drm/i915: move PCH pfit controls into pipe_config Jesse Barnes
2013-04-24 15:05 ` [PATCH 1/2] drm/i915: factor out GMCH panel fitting code and use for eDP v2 Mika Kuoppala
2013-04-24 15:29 ` Jesse Barnes
2013-04-24 16:56 ` Daniel Vetter [this message]
2013-04-25 14:38 ` Mika Kuoppala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130424165632.GX6169@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox