From: Daniel Vetter <daniel@ffwll.ch>
To: Paulo Zanoni <przanoni@gmail.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: fix Haswell pfit power well check v2
Date: Fri, 3 May 2013 18:22:27 +0200 [thread overview]
Message-ID: <20130503162227.GN5763@phenom.ffwll.local> (raw)
In-Reply-To: <CA+gsUGQZXe2Cc_CwbttzgT2R9PaPtX8nROmvNy8ceWEh2hRp-w@mail.gmail.com>
On Fri, May 03, 2013 at 12:01:49PM -0300, Paulo Zanoni wrote:
> 2013/5/3 Mika Kuoppala <mika.kuoppala@linux.intel.com>:
> > Jesse Barnes <jbarnes@virtuousgeek.org> writes:
> >
> >> We can't read the pfit regs if the power well is off, so use the cached
> >> value.
> >>
> >> v2: re-add lost comment (Jesse)
> >> make sure the crtc using the fitter is actually enabled (Jesse)
> >>
> >> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> >> ---
> >> drivers/gpu/drm/i915/intel_display.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> >> index 6504337..6be34f2 100644
> >> --- a/drivers/gpu/drm/i915/intel_display.c
> >> +++ b/drivers/gpu/drm/i915/intel_display.c
> >> @@ -5918,7 +5918,7 @@ static void haswell_modeset_global_resources(struct drm_device *dev)
> >> * sequence that's not yet available. Just in case desktop eDP
> >> * on PORT D is possible on haswell, too. */
> >> /* Even the eDP panel fitter is outside the always-on well. */
> >> - if (I915_READ(PF_WIN_SZ(crtc->pipe)))
> >> + if (crtc->config.pch_pfit.size && crtc->base.enabled)
> >> enable = true;
> >> }
> >>
> >
> > Remove the now useless *dev_priv to remove compiler warning and then add
> >
> > Reviewed-by: Mika Kuoppala <mika.kuoppala@intel.com>
>
> Yay, dmesg is clean again with this patch + Daniel's patch 06 + my
> local patches which I'll resend today.
>
> With the warn pointed by Mika removed:
> Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> Tested-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Queued for -next, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2013-05-03 16:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-02 22:24 [PATCH] drm/i915: fix Haswell pfit power well check Jesse Barnes
2013-05-02 22:30 ` [PATCH] drm/i915: fix Haswell pfit power well check v2 Jesse Barnes
2013-05-03 11:22 ` Daniel Vetter
2013-05-03 12:55 ` Mika Kuoppala
2013-05-03 15:01 ` Paulo Zanoni
2013-05-03 16:22 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130503162227.GN5763@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=przanoni@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox