[PATCH] drm/i915: fix panel fitting on LVDS on ILK+

[PATCH] drm/i915: fix panel fitting on LVDS on ILK+

[Jesse Barnes]

In refactoring this, it was only applied to eDP, which is incorrect.  In
fact, if we ever use the panel fitter to deal with overscan on HDMI,
we'll need to extend it again.

Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
---
 drivers/gpu/drm/i915/intel_display.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index aa99b4d..f9894cf 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -3240,7 +3240,8 @@ static void ironlake_pfit_enable(struct intel_crtc *crtc)
 	int pipe = crtc->pipe;
 
 	if (crtc->config.pch_pfit.size &&
-	    intel_pipe_has_type(&crtc->base, INTEL_OUTPUT_EDP)) {
+	    (intel_pipe_has_type(&crtc->base, INTEL_OUTPUT_EDP) ||
+	     intel_pipe_has_type(&crtc->base, INTEL_OUTPUT_LVDS))) {
 		/* Force use of hard-coded filter coefficients
 		 * as some pre-programmed values are broken,
 		 * e.g. x201.
-- 
1.7.9.5

Re: [PATCH] drm/i915: fix panel fitting on LVDS on ILK+

[Daniel Vetter]

On Fri, May 3, 2013 at 10:03 PM, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> In refactoring this, it was only applied to eDP, which is incorrect.  In
> fact, if we ever use the panel fitter to deal with overscan on HDMI,
> we'll need to extend it again.
>
> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>

Citation of regressing commit is missing. Also, since the pfit is
per-pipe on ilk+, shouldn't we just drop this?
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

Re: [PATCH] drm/i915: fix panel fitting on LVDS on ILK+

[Jesse Barnes]

On Fri, 3 May 2013 22:15:27 +0200
Daniel Vetter <daniel@ffwll.ch> wrote:

> On Fri, May 3, 2013 at 10:03 PM, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> > In refactoring this, it was only applied to eDP, which is incorrect.  In
> > fact, if we ever use the panel fitter to deal with overscan on HDMI,
> > we'll need to extend it again.
> >
> > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> 
> Citation of regressing commit is missing. Also, since the pfit is
> per-pipe on ilk+, shouldn't we just drop this?

Drop the conditional?  Sure if you want...

-- 
Jesse Barnes, Intel Open Source Technology Center

[PATCH] drm/i915: fix panel fitting on LVDS on ILK+ v2

[Jesse Barnes]

This regression was introduced in:

commit b074cec8c652f2d273907a4b35239b4766c894ac
Author: Jesse Barnes <jbarnes@virtuousgeek.org>
Date:   Thu Apr 25 12:55:02 2013 -0700

    drm/i915: move PCH pfit controls into pipe_config

In refactoring this, it was only applied to eDP, which is incorrect.  In
fact, if we ever use the panel fitter to deal with overscan on HDMI,
we'll need to extend it again, so just drop the conditional altogether.

v2: drop check for eDP since we can use the fitter in any config (Daniel)

Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
---
 drivers/gpu/drm/i915/intel_display.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index aa99b4d..7b4005b 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -3239,8 +3239,7 @@ static void ironlake_pfit_enable(struct intel_crtc *crtc)
 	struct drm_i915_private *dev_priv = dev->dev_private;
 	int pipe = crtc->pipe;
 
-	if (crtc->config.pch_pfit.size &&
-	    intel_pipe_has_type(&crtc->base, INTEL_OUTPUT_EDP)) {
+	if (crtc->config.pch_pfit.size) {
 		/* Force use of hard-coded filter coefficients
 		 * as some pre-programmed values are broken,
 		 * e.g. x201.
-- 
1.7.9.5

Re: [PATCH] drm/i915: fix panel fitting on LVDS on ILK+ v2

[Daniel Vetter]

On Fri, May 03, 2013 at 01:26:37PM -0700, Jesse Barnes wrote:
> This regression was introduced in:
> 
> commit b074cec8c652f2d273907a4b35239b4766c894ac
> Author: Jesse Barnes <jbarnes@virtuousgeek.org>
> Date:   Thu Apr 25 12:55:02 2013 -0700
> 
>     drm/i915: move PCH pfit controls into pipe_config
> 
> In refactoring this, it was only applied to eDP, which is incorrect.  In
> fact, if we ever use the panel fitter to deal with overscan on HDMI,
> we'll need to extend it again, so just drop the conditional altogether.
> 
> v2: drop check for eDP since we can use the fitter in any config (Daniel)
> 
> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>

Queued for -next, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch