From: Ben Widawsky <ben@bwidawsk.net>
To: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, miku@iki.fi
Subject: Re: [PATCH 2/2] drm/i915: add context into request struct
Date: Mon, 6 May 2013 22:12:29 -0700 [thread overview]
Message-ID: <20130507051229.GA11168@bwidawsk.net> (raw)
In-Reply-To: <871u9k5ufh.fsf@gaia.fi.intel.com>
On Mon, May 06, 2013 at 12:28:18PM +0300, Mika Kuoppala wrote:
> Ben Widawsky <ben@bwidawsk.net> writes:
>
> > On Thu, May 02, 2013 at 04:48:08PM +0300, Mika Kuoppala wrote:
> >> Storing context reference into request struct
> >> allows us to inspect context and its associated
> >> objects when requests are retired.
> >>
> >> Both ppgtt and arb robustness work will need
> >> this.
> >>
> >> Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
> >
> > Both 1&2 are:
> > Reviewed-by: Ben Widawsky <ben@bwidawsk.net>
> >
> > You should add your sob to 1, since you modified it (slightly), and
> > maybe run them both my Chris to make sure he approves as well.
>
> I took 1/2 from:
> http://cgit.freedesktop.org/~bwidawsk/drm-intel/commit/?h=ppgtt-ctx&id=5e266650d53d42ebbc8c22f2846c8ed87d747b21
>
> and i don't remember intentionally modifying it. Is there some merge fallout I
> missed? I couldn't spot any diff to original.
>
> -Mika
Ah, I see. The original patch from Chris had all 4 args to add request.
My patch had already fixed it :-D
--
Ben Widawsky, Intel Open Source Technology Center
prev parent reply other threads:[~2013-05-07 5:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-02 13:48 [PATCH 1/2] drm/i915: put context upon switching Mika Kuoppala
2013-05-02 13:48 ` [PATCH 2/2] drm/i915: add context into request struct Mika Kuoppala
2013-05-04 0:07 ` Ben Widawsky
2013-05-06 9:22 ` Daniel Vetter
2013-05-06 9:28 ` Mika Kuoppala
2013-05-07 5:12 ` Ben Widawsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130507051229.GA11168@bwidawsk.net \
--to=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kuoppala@linux.intel.com \
--cc=miku@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox