Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Widawsky <ben@bwidawsk.net>
To: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, miku@iki.fi
Subject: Re: [PATCH 2/2] drm/i915: add context into request struct
Date: Fri, 3 May 2013 17:07:42 -0700	[thread overview]
Message-ID: <20130504000742.GA954@bwidawsk.net> (raw)
In-Reply-To: <1367502488-4108-2-git-send-email-mika.kuoppala@intel.com>

On Thu, May 02, 2013 at 04:48:08PM +0300, Mika Kuoppala wrote:
> Storing context reference into request struct
> allows us to inspect context and its associated
> objects when requests are retired.
> 
> Both ppgtt and arb robustness work will need
> this.
> 
> Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>

Both 1&2 are:
Reviewed-by: Ben Widawsky <ben@bwidawsk.net>

You should add your sob to 1, since you modified it (slightly), and
maybe run them both my Chris to make sure he approves as well.

Thanks a lot of reworking the series to this order :D

[snip]

-- 
Ben Widawsky, Intel Open Source Technology Center

  reply	other threads:[~2013-05-04  0:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-02 13:48 [PATCH 1/2] drm/i915: put context upon switching Mika Kuoppala
2013-05-02 13:48 ` [PATCH 2/2] drm/i915: add context into request struct Mika Kuoppala
2013-05-04  0:07   ` Ben Widawsky [this message]
2013-05-06  9:22     ` Daniel Vetter
2013-05-06  9:28     ` Mika Kuoppala
2013-05-07  5:12       ` Ben Widawsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130504000742.GA954@bwidawsk.net \
    --to=ben@bwidawsk.net \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=mika.kuoppala@linux.intel.com \
    --cc=miku@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox