From: Ben Widawsky <ben@bwidawsk.net>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Intel GFX <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 2/4] [v2] drm/i915: Unbind the fb
Date: Fri, 31 May 2013 13:08:59 -0700 [thread overview]
Message-ID: <20130531200859.GA14189@bwidawsk.net> (raw)
In-Reply-To: <20130531193932.GE11399@cantiga.alporthouse.com>
On Fri, May 31, 2013 at 08:39:32PM +0100, Chris Wilson wrote:
> On Fri, May 31, 2013 at 11:45:29AM -0700, Ben Widawsky wrote:
> > This is the only place I could find where we don't already unbind the
> > object before freeing it. This change will allow us to have a nice
> > assertion on free about whether or not an object still has pinned pages.
> >
> > v2: Just use the i915 object instead of casting
>
> The patch is flawed in that we try to do the unbind without mutex
> protection. But it should already be unbound in free_object() anyway -
> and doing so here is unlikely to fix the WARN_ON (presuming that is
> what you are chasing).
> -Chris
>
> --
> Chris Wilson, Intel Open Source Technology Centre
Agreed. This patch is junk. I made the mistake of working on it when I
should have been in bed.
--
Ben Widawsky, Intel Open Source Technology Center
next prev parent reply other threads:[~2013-05-31 20:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-31 18:28 [PATCH 1/4] drm/i915: Demote unknown param to DRM_DEBUG Ben Widawsky
2013-05-31 18:28 ` [PATCH 2/4] drm/i915: Unbind the fb Ben Widawsky
2013-05-31 18:45 ` [PATCH 2/4] [v2] " Ben Widawsky
2013-05-31 19:39 ` Chris Wilson
2013-05-31 20:08 ` Ben Widawsky [this message]
2013-05-31 18:28 ` [PATCH 3/4] drm/i915: unpin pages at unbind Ben Widawsky
2013-05-31 18:46 ` Chris Wilson
2013-05-31 21:46 ` [PATCH 1/2] drm/i915: Make stolen use pin pages Ben Widawsky
2013-05-31 21:44 ` Ben Widawsky
2013-05-31 21:46 ` [PATCH 2/2] drm/i915: Unpin stolen pages Ben Widawsky
2013-05-31 23:51 ` Chris Wilson
2013-06-01 9:17 ` Daniel Vetter
2013-06-01 11:34 ` Chris Wilson
2013-06-01 13:13 ` Daniel Vetter
2013-06-03 8:36 ` Chris Wilson
2013-06-03 8:52 ` Daniel Vetter
2013-06-03 22:54 ` Ben Widawsky
2013-05-31 18:28 ` [PATCH 4/4] drm/i915: Rename the gtt_list to global_list Ben Widawsky
2013-05-31 18:40 ` Chris Wilson
2013-05-31 18:38 ` [PATCH 1/4] drm/i915: Demote unknown param to DRM_DEBUG Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130531200859.GA14189@bwidawsk.net \
--to=ben@bwidawsk.net \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox