From: Daniel Vetter <daniel@ffwll.ch>
To: Imre Deak <imre.deak@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: hw state readout support for pixel_multiplier
Date: Thu, 6 Jun 2013 14:59:09 +0200 [thread overview]
Message-ID: <20130606125909.GF7827@phenom.ffwll.local> (raw)
In-Reply-To: <1370519415.23133.5.camel@intelbox>
On Thu, Jun 06, 2013 at 02:50:15PM +0300, Imre Deak wrote:
> On Thu, 2013-06-06 at 12:45 +0200, Daniel Vetter wrote:
> > Incomplete since ilk+ support needs proper pch dpll tracking first.
> > SDVO get_config parts based on a patch from Jesse Barnes, but fixed up
> > to actually work.
> >
> > v2: Make sure that we call encoder->get_config _after_ we
> > get_pipe_config to be consistent in both setup_hw_state and the
> > modeset state checker. Otherwise the clever trick with handling the
> > pixel mutliplier on i915G/GM where the encoder overrides the default
> > value of 1 from the crtc get_pipe_config function doesn't work.
> > Spotted by Imre Deak.
> >
> > v3: Actually cross-check the pixel mutliplier (but not on pch split
> > platforms for now). Now actually also tested on a i915G with a sdvo
> > encoder plugged in.
> >
> > Cc: <imre.deak@intel.com>
> > Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> Looks ok,
> Reviewed-by: Imre Deak <imre.deak@intel.com>
Queued for -next, thanks for the review.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2013-06-06 12:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-01 15:17 [PATCH 1/2] drm/i915: set default value for config->pixel_multiplier Daniel Vetter
2013-06-01 15:17 ` [PATCH 2/2] drm/i915: hw state readout support for pixel_multiplier Daniel Vetter
2013-06-05 15:01 ` Imre Deak
2013-06-05 20:16 ` Daniel Vetter
2013-06-06 10:45 ` [PATCH] " Daniel Vetter
2013-06-06 11:50 ` Imre Deak
2013-06-06 12:59 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130606125909.GF7827@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@ffwll.ch \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox