From: Chris Wilson <chris@chris-wilson.co.uk>
To: Rodrigo Vivi <rodrigo.vivi@gmail.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: WA: FBC Render Nuke.
Date: Thu, 6 Jun 2013 16:00:45 +0100 [thread overview]
Message-ID: <20130606150045.GD20552@cantiga.alporthouse.com> (raw)
In-Reply-To: <1370530196-1712-1-git-send-email-rodrigo.vivi@gmail.com>
On Thu, Jun 06, 2013 at 11:49:56AM -0300, Rodrigo Vivi wrote:
> WaFbcNukeOn3DBlt for IVB, HSW.
>
> According BSPec: "Workaround: Do not enable Render Command Streamer tracking for FBC.
> Instead insert a LRI to address 0x50380 with data 0x00000004 after the PIPE_CONTROL that
> follows each render submission."
>
> v2: Chris noticed that flush_domains check was missing here and also suggested to do
> LRI only when fbc is enabled. To avoid do a I915_READ on every flush lets use the
> module parameter check.
>
> v3: Adding Wa name as Damien suggested.
>
> v4: Ville noticed VLV doesn't support fbc at all and comment came wrong from spec.
>
> v5: Ville noticed than on blt a Cache Clean LRI should be used instead the Nuke one.
>
> v6: Check for flush domain on blt (by Ville).
> Check for scanout dirty (by Chris).
Note quite what I had in mind, see
https://patchwork.kernel.org/patch/2606131/
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2013-06-06 15:00 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-29 0:25 [PATCH] drm/i915: WA: FBC Render Nuke Rodrigo Vivi
2013-05-29 0:36 ` Rodrigo Vivi
2013-05-31 15:59 ` Ville Syrjälä
2013-05-31 20:15 ` Rodrigo Vivi
2013-06-03 11:34 ` Ville Syrjälä
2013-06-03 16:50 ` Rodrigo Vivi
2013-06-03 17:03 ` Ville Syrjälä
2013-06-03 18:41 ` Rodrigo Vivi
2013-06-04 7:06 ` Ville Syrjälä
2013-06-04 8:09 ` Chris Wilson
2013-06-06 14:49 ` Rodrigo Vivi
2013-06-06 15:00 ` Chris Wilson [this message]
2013-06-06 15:16 ` Rodrigo Vivi
2013-06-06 19:53 ` [PATCH 1/2] drm/i915: Track when we dirty the scanout with render commands Rodrigo Vivi
2013-06-06 19:53 ` Rodrigo Vivi
2013-06-06 19:53 ` [PATCH 2/2] drm/i915: WA: FBC Render Nuke Rodrigo Vivi
2013-06-06 19:58 ` [PATCH] " Rodrigo Vivi
2013-06-07 15:58 ` Daniel Vetter
2013-06-03 17:08 ` Rodrigo Vivi
2013-06-03 17:10 ` Rodrigo Vivi
-- strict thread matches above, loose matches on Subject: below --
2013-05-22 17:23 Rodrigo Vivi
2013-05-23 9:48 ` Ville Syrjälä
2013-05-23 10:28 ` Damien Lespiau
2013-05-23 18:06 ` Rodrigo Vivi
2013-05-24 8:13 ` Ville Syrjälä
2013-05-22 10:57 Rodrigo Vivi
2013-05-22 14:21 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130606150045.GD20552@cantiga.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox