* [PATCH] drm/i915: don't scream into dmesg when a modeset fails
@ 2013-06-25 9:06 Daniel Vetter
2013-06-25 9:10 ` Chris Wilson
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Vetter @ 2013-06-25 9:06 UTC (permalink / raw)
To: Intel Graphics Development; +Cc: Daniel Vetter
There are legit cases, e.g. when userspace asks for something
impossible. So tune it down to debug output like we do with all other
userspace-triggerable warnings.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=66111#c5
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
drivers/gpu/drm/i915/intel_display.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index af2b5ab..d86336b 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -8721,8 +8721,8 @@ static int intel_crtc_set_config(struct drm_mode_set *set)
ret = intel_set_mode(set->crtc, set->mode,
set->x, set->y, set->fb);
if (ret) {
- DRM_ERROR("failed to set mode on [CRTC:%d], err = %d\n",
- set->crtc->base.id, ret);
+ DRM_DEBUG_KMS("failed to set mode on [CRTC:%d], err = %d\n",
+ set->crtc->base.id, ret);
goto fail;
}
} else if (config->fb_changed) {
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/i915: don't scream into dmesg when a modeset fails
2013-06-25 9:06 [PATCH] drm/i915: don't scream into dmesg when a modeset fails Daniel Vetter
@ 2013-06-25 9:10 ` Chris Wilson
2013-06-25 9:39 ` Daniel Vetter
0 siblings, 1 reply; 3+ messages in thread
From: Chris Wilson @ 2013-06-25 9:10 UTC (permalink / raw)
To: Daniel Vetter; +Cc: Intel Graphics Development
On Tue, Jun 25, 2013 at 11:06:52AM +0200, Daniel Vetter wrote:
> There are legit cases, e.g. when userspace asks for something
> impossible. So tune it down to debug output like we do with all other
> userspace-triggerable warnings.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=66111#c5
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/i915: don't scream into dmesg when a modeset fails
2013-06-25 9:10 ` Chris Wilson
@ 2013-06-25 9:39 ` Daniel Vetter
0 siblings, 0 replies; 3+ messages in thread
From: Daniel Vetter @ 2013-06-25 9:39 UTC (permalink / raw)
To: Chris Wilson, Daniel Vetter, Intel Graphics Development
On Tue, Jun 25, 2013 at 10:10:49AM +0100, Chris Wilson wrote:
> On Tue, Jun 25, 2013 at 11:06:52AM +0200, Daniel Vetter wrote:
> > There are legit cases, e.g. when userspace asks for something
> > impossible. So tune it down to debug output like we do with all other
> > userspace-triggerable warnings.
> >
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=66111#c5
> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Queued for -next, thanks for the review.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-06-25 9:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-25 9:06 [PATCH] drm/i915: don't scream into dmesg when a modeset fails Daniel Vetter
2013-06-25 9:10 ` Chris Wilson
2013-06-25 9:39 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox