From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: ville.syrjala@linux.intel.com
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] Revert "drm/i915: Don't use the HDMI port color range bit on Valleyview"
Date: Wed, 26 Jun 2013 07:53:31 -0700 [thread overview]
Message-ID: <20130626075331.22fcbdae@jbarnes-desktop> (raw)
In-Reply-To: <1372158995-16945-1-git-send-email-ville.syrjala@linux.intel.com>
On Tue, 25 Jun 2013 14:16:34 +0300
ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> The PIPECONF color range bit doesn't appear to be effective, on HDMI
> outputs at least. The color range bit in the port register works though,
> so let's use it.
>
> I have not yet verified whether the PIPECONF bit works on DP outputs.
>
> This reverts commit 83a2af88f80ebf8104c9e083b786668b00f5b9ce.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_hdmi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
> index bc12518..98df2a0 100644
> --- a/drivers/gpu/drm/i915/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/intel_hdmi.c
> @@ -602,7 +602,7 @@ static void intel_hdmi_mode_set(struct drm_encoder *encoder,
> u32 hdmi_val;
>
> hdmi_val = SDVO_ENCODING_HDMI;
> - if (!HAS_PCH_SPLIT(dev) && !IS_VALLEYVIEW(dev))
> + if (!HAS_PCH_SPLIT(dev))
> hdmi_val |= intel_hdmi->color_range;
> if (adjusted_mode->flags & DRM_MODE_FLAG_PVSYNC)
> hdmi_val |= SDVO_VSYNC_ACTIVE_HIGH;
Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
--
Jesse Barnes, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2013-06-26 17:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-25 11:16 [PATCH 1/2] Revert "drm/i915: Don't use the HDMI port color range bit on Valleyview" ville.syrjala
2013-06-25 11:16 ` [PATCH 2/2] drm/i915: Fix VLV sprite register offsets ville.syrjala
2013-06-26 14:50 ` Jesse Barnes
2013-06-26 18:44 ` Daniel Vetter
2013-06-26 19:05 ` Ville Syrjälä
2013-06-26 14:53 ` Jesse Barnes [this message]
2013-06-26 18:43 ` [PATCH 1/2] Revert "drm/i915: Don't use the HDMI port color range bit on Valleyview" Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130626075331.22fcbdae@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox