Re: [PATCH 1/2] Revert "drm/i915: Don't use the HDMI port color range bit on Valleyview"

[Daniel Vetter <daniel@ffwll.ch>]

On Wed, Jun 26, 2013 at 07:53:31AM -0700, Jesse Barnes wrote:
> On Tue, 25 Jun 2013 14:16:34 +0300
> ville.syrjala@linux.intel.com wrote:
> 
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > 
> > The PIPECONF color range bit doesn't appear to be effective, on HDMI
> > outputs at least. The color range bit in the port register works though,
> > so let's use it.
> > 
> > I have not yet verified whether the PIPECONF bit works on DP outputs.
> > 
> > This reverts commit 83a2af88f80ebf8104c9e083b786668b00f5b9ce.
> > 
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> >  drivers/gpu/drm/i915/intel_hdmi.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
> > index bc12518..98df2a0 100644
> > --- a/drivers/gpu/drm/i915/intel_hdmi.c
> > +++ b/drivers/gpu/drm/i915/intel_hdmi.c
> > @@ -602,7 +602,7 @@ static void intel_hdmi_mode_set(struct drm_encoder *encoder,
> >  	u32 hdmi_val;
> >  
> >  	hdmi_val = SDVO_ENCODING_HDMI;
> > -	if (!HAS_PCH_SPLIT(dev) && !IS_VALLEYVIEW(dev))
> > +	if (!HAS_PCH_SPLIT(dev))
> >  		hdmi_val |= intel_hdmi->color_range;
> >  	if (adjusted_mode->flags & DRM_MODE_FLAG_PVSYNC)
> >  		hdmi_val |= SDVO_VSYNC_ACTIVE_HIGH;
> 
> Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>

Queued for -next, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch