From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: Refactor the wait_rendering completion into a common routine
Date: Sat, 29 Jun 2013 22:03:52 +0200 [thread overview]
Message-ID: <20130629200352.GA18285@phenom.ffwll.local> (raw)
In-Reply-To: <20130629155519.GZ18285@phenom.ffwll.local>
On Sat, Jun 29, 2013 at 05:55:19PM +0200, Daniel Vetter wrote:
> On Sat, Jun 29, 2013 at 04:35:57PM +0200, Daniel Vetter wrote:
> > On Sat, Jun 29, 2013 at 9:36 AM, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > > Harmonise the completion logic between the non-blocking and normal
> > > wait_rendering paths, and move that logic into a common function.
> > >
> > > In the process, we note that the last_write_seqno is by definition the
> > > earlier of the two read/write seqnos and so all successful waits will
> > > have passed the last_write_seqno. Therefore we can unconditionally clear
> > > the write seqno and its domains in the completion logic.
> > >
> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> >
> > Looks really nice. Still I'd like to see some i-g-t nastiness
> > increases before we frob this code some more. So I'll punt on this for
> > now ...
>
> I'm happy about the new tests, so merged this patch to dinq. Thanks for
> botht the cleanup and the igt tests.
Oops, didn't spot that the compile failed and hence the branch was never
pushed. Can I have v2 please?
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2013-06-29 20:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-29 7:36 [PATCH] drm/i915: Refactor the wait_rendering completion into a common routine Chris Wilson
2013-06-29 14:35 ` Daniel Vetter
2013-06-29 15:55 ` Daniel Vetter
2013-06-29 20:03 ` Daniel Vetter [this message]
2013-06-29 21:05 ` Chris Wilson
2013-06-29 21:34 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130629200352.GA18285@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox