From: Ben Widawsky <ben@bwidawsk.net>
To: ville.syrjala@linux.intel.com
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t 1/3] quick_dump: Add automagic DPIO register support
Date: Sun, 30 Jun 2013 22:09:25 -0700 [thread overview]
Message-ID: <20130701050925.GD10701@bwidawsk.net> (raw)
In-Reply-To: <1372269454-31057-1-git-send-email-ville.syrjala@linux.intel.com>
On Wed, Jun 26, 2013 at 08:57:32PM +0300, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Repurpose the (currently unused) third element in the register
> definition tuple to indicate the type of the register. 'DPIO'
> is the only special register type for now.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> tools/quick_dump/quick_dump.py | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tools/quick_dump/quick_dump.py b/tools/quick_dump/quick_dump.py
> index 6111b5d..390cafa 100755
> --- a/tools/quick_dump/quick_dump.py
> +++ b/tools/quick_dump/quick_dump.py
> @@ -13,7 +13,10 @@ def parse_file(file):
> print('-' * 54)
> for line in file:
> register = ast.literal_eval(line)
> - val = reg.read(register[1])
> + if register[2] == 'DPIO':
> + val = reg.dpio_read(register[1])
> + else:
> + val = reg.read(register[1])
> intreg = int(register[1], 16)
> print('{0:#010x} | {1:<28} | {2:#010x}'.format(intreg, register[0], val))
> print('')
I can't recall if you have push access, but I've pushed it.
--
Ben Widawsky, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2013-07-01 5:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-26 17:57 [PATCH i-g-t 1/3] quick_dump: Add automagic DPIO register support ville.syrjala
2013-06-26 17:57 ` [PATCH i-g-t 2/3] quick_dump: Document the register definition format ville.syrjala
2013-06-26 17:57 ` [PATCH i-g-t v2 3/3] quick_dump: Add VLV DPIO registers ville.syrjala
2013-06-26 18:48 ` Ben Widawsky
2013-07-01 5:09 ` Ben Widawsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130701050925.GD10701@bwidawsk.net \
--to=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox