public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Ben Widawsky <ben@bwidawsk.net>
To: ville.syrjala@linux.intel.com
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 00/30] drm/i915: Lots of workaround changes
Date: Fri, 5 Jul 2013 12:51:54 -0700	[thread overview]
Message-ID: <20130705195154.GB3716@bwidawsk.net> (raw)
In-Reply-To: <1373032128-23755-1-git-send-email-ville.syrjala@linux.intel.com>

On Fri, Jul 05, 2013 at 04:48:18PM +0300, ville.syrjala@linux.intel.com wrote:
> I was going over the workaround database with VLV mainly in mind, but I
> ended up stumbling on quite a few others as well.
> 
> This series adds the workarounds names in a bunch of places where we
> missed them, adds a few workarounds we seem to have missed, drops some
> that were never supposed to be there, and drops quite a few pre-production
> workarounds.
> 
> I'm not sure we want to drop some of the VLV workarounds quite yet. I know
> Jani will hate me when he comes back from vacation since his current machine
> would be affected.
> 
> I've run these on my VLV and IVB machines, and didn't spot any problems.
> The SNB and HSW ones I've not actually tested.

I have a sneaking suspicion at least a few of these will blow up once
their in the wild. You're trusting the docs an awful lot. At least the
patches seem quite bisectable though, so that's a saving grace.

One thing which might be interesting/compelling is some performance data
(especially around places where you've removed unneeded workarounds).

> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ben Widawsky, Intel Open Source Technology Center

  parent reply	other threads:[~2013-07-05 19:48 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-05 13:48 [PATCH 00/30] drm/i915: Lots of workaround changes ville.syrjala
2013-07-05 13:48 ` [PATCH 01/30] drm/i915: We implement WaDisableL3Bank2xClockGate:vlv ville.syrjala
2013-07-05 13:48 ` [PATCH 02/30] drm/i915: We implement WaGsvBringDownFreqInRc6:vlv ville.syrjala
2013-07-05 13:48 ` [PATCH 03/30] drm/i915: We implement WaEnableVGAAccessThroughIOPort:ctg, elk, ilk, snb, ivb, vlv, hsw ville.syrjala
2013-07-05 13:48 ` [PATCH 04/30] drm/i915: WaPsdDispatchEnable seems to be another name for WaDisablePSDDualDispatchEnable ville.syrjala
2013-07-05 13:48 ` [PATCH 05/30] drm/i915: We implement WaDisableL3CacheAging:vlv ville.syrjala
2013-07-05 13:48 ` [PATCH 06/30] drm/i915: We implement WaDisableDopClockGating:ivb ville.syrjala
2013-07-05 13:48 ` [PATCH 07/30] drm/i915: We implement WaDisableRCCUnitClockGating:snb ville.syrjala
2013-07-05 13:48 ` [PATCH 08/30] drm/i915: We implement WaMiSetContext_Hang ville.syrjala
2013-07-05 14:05   ` Chris Wilson
2013-07-05 13:48 ` [PATCH 09/30] drm/i915: Rename GEN7_MISCCPCTL to GEN6_MISCCPCTL ville.syrjala
2013-07-05 13:48 ` [PATCH 10/30] drm/i915: Implement WaDisableDopClockGating:snb ville.syrjala
2013-07-05 19:49   ` Ben Widawsky
2013-08-01 14:58   ` Ville Syrjälä
2013-07-05 13:48 ` [PATCH 11/30] drm/i915: Fix IVB GT2 WaDisableDopClockGating and WaDisablePSDDualDispatchEnable ville.syrjala
2013-07-05 13:48 ` [PATCH 12/30] drm/i915: Drop WaDisablePSDDualDispatchEnable:ivb for IVB GT2 ville.syrjala
2013-07-05 13:48 ` [PATCH 13/30] drm/i915: Implement WaIncreaseL3CreditsForVLVB0:vlv ville.syrjala
2013-07-05 13:48 ` [PATCH 14/30] drm/i915: WaDisableVDSUnitClockGating isn't applicable to SNB ville.syrjala
2013-07-05 13:48 ` [PATCH 15/30] drm/i915: WaDisableRCCUnitClockGating isn't applicable to IVB ville.syrjala
2013-07-05 13:48 ` [PATCH 16/30] drm/i915: WaDisableRCCUnitClockGating isn't applicaple to VLV ville.syrjala
2013-07-05 13:48 ` [PATCH 17/30] drm/i915: WaDisableRHWOOptimizationForRenderHang isn't applicable to HSW ville.syrjala
2013-07-05 13:48 ` [PATCH 18/30] drm/i915: WaDisableRHWOOptimizationForRenderHang isn't applicable to VLV ville.syrjala
2013-07-05 13:48 ` [PATCH 19/30] drm/i915: WaApplyL3ControlAndL3ChickenMode isn't applicable for VLV ville.syrjala
2013-07-05 13:48 ` [PATCH 20/30] drm/i915: Drop bogus comment about RCPB unit clock gating on IVB ville.syrjala
2013-07-05 13:48 ` [PATCH 21/30] drm/i915: Drop WaDisableRCZUnitClockGating:hsw ville.syrjala
2013-07-05 13:48 ` [PATCH 22/30] drm/i915: Drop WaApplyL3ControlAndL3ChickenMode:hsw ville.syrjala
2013-07-05 13:48 ` [PATCH 23/30] drm/i915: Drop WaDisableRCPBUnitClockGating:vlv ville.syrjala
2013-07-05 13:48 ` [PATCH 24/30] drm/i915: Drop WaDisableVDSUtnitClockGating:vlv ville.syrjala
2013-07-05 13:48 ` [PATCH 25/30] drm/i915: Drop WaDisableTDLUnitClockGating:vlv ville.syrjala
2013-07-05 13:48 ` [PATCH 26/30] drm/i915: gen7_setup_fixed_func_scheduler() actually implements WaVSThreadDispatchOverride ville.syrjala
2013-07-05 13:48 ` [PATCH 27/30] drm/i915: Don't apply WaVSThreadDispatchOverride on HSW ville.syrjala
2013-07-05 13:48 ` [PATCH 28/30] drm/i915: VLV wants WaVSThreadDispatchOverride too ville.syrjala
2013-07-05 13:48 ` [PATCH 29/30] drm/i915: WaDisableDopClockGating isn't applicable to IVB ville.syrjala
2013-07-05 13:48 ` [PATCH 30/30] drm/i915: Clarify WaDisable4x2SubspanOptimization situation for VLV ville.syrjala
2013-07-05 19:51 ` Ben Widawsky [this message]
2013-07-05 20:02   ` [PATCH 00/30] drm/i915: Lots of workaround changes Ville Syrjälä
2013-07-05 20:13     ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130705195154.GB3716@bwidawsk.net \
    --to=ben@bwidawsk.net \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox