From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
stable@vger.kernel.org
Subject: Re: [PATCH] drm/i915: fix up ring cleanup for the i830/i845 CS tlb w/a
Date: Sat, 6 Jul 2013 01:15:55 +0200 [thread overview]
Message-ID: <20130705231555.GD18285@phenom.ffwll.local> (raw)
In-Reply-To: <20130705225341.GB13441@cantiga.alporthouse.com>
On Fri, Jul 05, 2013 at 11:53:41PM +0100, Chris Wilson wrote:
> On Fri, Jul 05, 2013 at 11:39:50PM +0200, Daniel Vetter wrote:
> > It's not a good idea to also run the pipe_control cleanup.
> >
> > This regression has been introduced whith the original cs tlb w/a in
> >
> > commit b45305fce5bb1abec263fcff9d81ebecd6306ede
> > Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Date: Mon Dec 17 16:21:27 2012 +0100
> >
> > drm/i915: Implement workaround for broken CS tlb on i830/845
> >
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=64610
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> Just promise me on the next ring->private, we will add a real
> destructor.
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Picked up for -fixes, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2013-07-05 23:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-05 21:39 [PATCH] drm/i915: fix up ring cleanup for the i830/i845 CS tlb w/a Daniel Vetter
2013-07-05 22:53 ` Chris Wilson
2013-07-05 23:15 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130705231555.GD18285@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox