public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Ben Widawsky <ben@bwidawsk.net>
To: Chris Wilson <chris@chris-wilson.co.uk>,
	Intel GFX <intel-gfx@lists.freedesktop.org>,
	Bryan Bell <bryan.j.bell@intel.com>
Subject: Re: [PATCH] drm/i915: Expose LLC size to user space
Date: Wed, 10 Jul 2013 09:40:18 -0700	[thread overview]
Message-ID: <20130710164018.GA3326@bwidawsk.net> (raw)
In-Reply-To: <20130710085901.GJ14388@cantiga.alporthouse.com>

On Wed, Jul 10, 2013 at 09:59:01AM +0100, Chris Wilson wrote:
> On Tue, Jul 09, 2013 at 07:58:02PM -0700, Ben Widawsky wrote:
> > The algorithm/information was originally written by Chad, though I
> > changed the control flow, and I think his original code had a couple of
> > bugs, though I didn't look very hard before rewriting. That could have
> > also been different interpretations of the spec.
> 
> Just a cpuid query that can already be done more simply from userspace
> (i.e. with no syscalls)? I was expecting a lot more magic.
> -Chris
> 
> -- 
> Chris Wilson, Intel Open Source Technology Centre

Chad wrote this originally for mesa. And yes, it's doable from
userspace. Chatting with Daniel, we thought maybe other GPU clients
might want this info, and so a central place to put the code would be
nice, in case there are quirks or anything like that (I've had a
particularly hard time figuring out if Xeon really has L3 or not).

So what's a central place? Libdrm, everybody uses that right? You can
read /proc/cpuinfo as far as I know, but then you still need to query
the HAS_LLC getparam to figure out what kind of L3 (or do your own
chipset ID check).

In addition to the centrality argument, I noticed while poking around
cpuid in the kernel that it is a vitalized function. I'm not sure what
the purpose of this is, but it's something you can't fake in userspace.


-- 
Ben Widawsky, Intel Open Source Technology Center

  reply	other threads:[~2013-07-10 16:40 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-10  2:58 [PATCH] drm/i915: Expose LLC size to user space Ben Widawsky
2013-07-10  2:58 ` [PATCH] intel_get_llc_size: Small tool to query LLC size Ben Widawsky
2013-07-10  6:34   ` Daniel Vetter
2013-07-10 16:58     ` Ben Widawsky
2013-07-10 17:15       ` Daniel Vetter
2013-07-10 17:24         ` Ben Widawsky
2013-07-10 17:45           ` Daniel Vetter
2013-07-10  8:59 ` [PATCH] drm/i915: Expose LLC size to user space Chris Wilson
2013-07-10 16:40   ` Ben Widawsky [this message]
2013-07-10 17:11     ` Ben Widawsky
2013-07-10 17:40     ` Chris Wilson
2013-07-10 17:46       ` Ben Widawsky
2013-07-10 18:00         ` Chris Wilson
2013-07-10 18:44           ` Ben Widawsky
2013-07-10 17:00 ` Bell, Bryan J
2013-07-11  0:16 ` Chad Versace
2013-07-11  5:06   ` Ben Widawsky
2013-07-11 18:52 ` [PATCH] [v2] " Ben Widawsky
2013-07-11 18:53   ` [PATCH 1/2] intel_get_llc_size: Small tool to query LLC size Ben Widawsky
2013-07-11 18:53     ` [PATCH 2/2] tests: Basic tools tester Ben Widawsky
2013-07-12 17:39     ` [PATCH 1/2] intel_get_llc_size: Small tool to query LLC size Chad Versace
2013-07-12 17:49       ` Ben Widawsky
2013-07-11 20:46   ` [PATCH] [v2] drm/i915: Expose LLC size to user space Chris Wilson
2013-07-12 17:38   ` Chad Versace

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130710164018.GA3326@bwidawsk.net \
    --to=ben@bwidawsk.net \
    --cc=bryan.j.bell@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox