[PATCH] drm/i915: remove preliminary_hw_support variable

[PATCH] drm/i915: remove preliminary_hw_support variable

[Jesse Barnes]

It's currently unused upstream, and just gets in the way internally.  If
things are really hosed for some reason on a given platform, users can
still pass a bogus param to i915 to disable it (e.g. for installers with
half baked hw support).  But really, if that happens in practice, we've
failed pretty hard to get things out and tested on time...

Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
---
 drivers/gpu/drm/i915/i915_drv.c |    5 -----
 drivers/gpu/drm/i915/i915_drv.h |    1 -
 2 files changed, 6 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 0485f43..53eac49 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -118,11 +118,6 @@ module_param_named(i915_enable_ppgtt, i915_enable_ppgtt, int, 0600);
 MODULE_PARM_DESC(i915_enable_ppgtt,
 		"Enable PPGTT (default: true)");
 
-unsigned int i915_preliminary_hw_support __read_mostly = 0;
-module_param_named(preliminary_hw_support, i915_preliminary_hw_support, int, 0600);
-MODULE_PARM_DESC(preliminary_hw_support,
-		"Enable preliminary hardware support. (default: false)");
-
 int i915_disable_power_well __read_mostly = 0;
 module_param_named(disable_power_well, i915_disable_power_well, int, 0600);
 MODULE_PARM_DESC(disable_power_well,
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 846500a..c1e268f 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -1580,7 +1580,6 @@ extern int i915_enable_rc6 __read_mostly;
 extern int i915_enable_fbc __read_mostly;
 extern bool i915_enable_hangcheck __read_mostly;
 extern int i915_enable_ppgtt __read_mostly;
-extern unsigned int i915_preliminary_hw_support __read_mostly;
 extern int i915_disable_power_well __read_mostly;
 extern int i915_enable_ips __read_mostly;
 extern bool i915_fastboot __read_mostly;
-- 
1.7.9.5

Re: [PATCH] drm/i915: remove preliminary_hw_support variable

[Daniel Vetter]

On Thu, Jul 11, 2013 at 03:44:03PM -0700, Jesse Barnes wrote:
> It's currently unused upstream, and just gets in the way internally.  If
> things are really hosed for some reason on a given platform, users can
> still pass a bogus param to i915 to disable it (e.g. for installers with
> half baked hw support).  But really, if that happens in practice, we've
> failed pretty hard to get things out and tested on time...

And we did fail pretty hard. Both haswell and baytrail have been enabled,
but with only half of all outputs even working and other serious issues.

Until we've demonstrated that we can do better I'd like to keep this.
-Daniel

> 
> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> ---
>  drivers/gpu/drm/i915/i915_drv.c |    5 -----
>  drivers/gpu/drm/i915/i915_drv.h |    1 -
>  2 files changed, 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index 0485f43..53eac49 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -118,11 +118,6 @@ module_param_named(i915_enable_ppgtt, i915_enable_ppgtt, int, 0600);
>  MODULE_PARM_DESC(i915_enable_ppgtt,
>  		"Enable PPGTT (default: true)");
>  
> -unsigned int i915_preliminary_hw_support __read_mostly = 0;
> -module_param_named(preliminary_hw_support, i915_preliminary_hw_support, int, 0600);
> -MODULE_PARM_DESC(preliminary_hw_support,
> -		"Enable preliminary hardware support. (default: false)");
> -
>  int i915_disable_power_well __read_mostly = 0;
>  module_param_named(disable_power_well, i915_disable_power_well, int, 0600);
>  MODULE_PARM_DESC(disable_power_well,
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index 846500a..c1e268f 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -1580,7 +1580,6 @@ extern int i915_enable_rc6 __read_mostly;
>  extern int i915_enable_fbc __read_mostly;
>  extern bool i915_enable_hangcheck __read_mostly;
>  extern int i915_enable_ppgtt __read_mostly;
> -extern unsigned int i915_preliminary_hw_support __read_mostly;
>  extern int i915_disable_power_well __read_mostly;
>  extern int i915_enable_ips __read_mostly;
>  extern bool i915_fastboot __read_mostly;
> -- 
> 1.7.9.5
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch