From: Ben Widawsky <ben@bwidawsk.net>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/6] drm/i915: Colocate all GT access routines in the same file
Date: Fri, 12 Jul 2013 10:56:55 -0700 [thread overview]
Message-ID: <20130712175655.GE15384@bwidawsk.net> (raw)
In-Reply-To: <1373648907-28774-1-git-send-email-chris@chris-wilson.co.uk>
On Fri, Jul 12, 2013 at 06:08:22PM +0100, Chris Wilson wrote:
> Currently, the register access code is split between i915_drv.c and
> intel_pm.c. It only bares a superficial resemblance to the reset of the
> powermanagement code, so move it all into its own file. This is to ease
> further patches to enforce serialised register access.
>
> v2: Scan for random abuse of I915_WRITE_NOTRACE
> v3: Take the opportunity to rename the GT functions as uncore. Uncore is
> the term used by the hardware design (and bspec) for all functions
> outside of the GPU (and CPU) cores in what is also known as the System
> Agent.
>
Bikesheds:
Would have preferred the gt/pm_init split as a separate patch.
intel_uncore_clear_errors/chec_errors seems silly to me.
Acked-by: Ben Widawsky <ben@bwidawsk.net>
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>
[snip]
--
Ben Widawsky, Intel Open Source Technology Center
next prev parent reply other threads:[~2013-07-12 17:57 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-12 17:08 [PATCH 1/6] drm/i915: Colocate all GT access routines in the same file Chris Wilson
2013-07-12 17:08 ` [PATCH 2/6] drm/i915: Use a private interface for register access within GT Chris Wilson
2013-07-14 19:48 ` Ben Widawsky
2013-07-16 16:18 ` Chris Wilson
2013-07-12 17:08 ` [PATCH 3/6] drm/i915: Use the common register access functions for NOTRACE variants Chris Wilson
2013-07-12 17:08 ` [PATCH 4/6] drm/i915: Serialize all register access Chris Wilson
2013-07-14 20:23 ` Ben Widawsky
2013-07-16 16:16 ` Chris Wilson
2013-07-12 17:08 ` [PATCH 5/6] drm/i915: Squash gen lookup through multiple indirections inside GT access Chris Wilson
2013-07-12 17:08 ` [PATCH 6/6] drm/i915: Convert the register access tracepoint to be conditional Chris Wilson
2013-07-14 20:28 ` Ben Widawsky
2013-07-16 16:09 ` Chris Wilson
2013-07-12 17:56 ` Ben Widawsky [this message]
2013-07-12 19:21 ` [PATCH 1/6] drm/i915: Colocate all GT access routines in the same file Chris Wilson
2013-07-14 19:42 ` Ben Widawsky
2013-07-14 20:37 ` Chris Wilson
2013-07-15 19:04 ` Paulo Zanoni
-- strict thread matches above, loose matches on Subject: below --
2013-07-16 19:02 Chris Wilson
2013-07-18 12:15 ` Daniel Vetter
2013-07-18 12:18 ` Daniel Vetter
2013-07-18 12:29 ` Chris Wilson
2013-07-18 12:29 ` Chris Wilson
2013-07-18 15:53 ` Daniel Vetter
2013-07-18 17:44 ` Chris Wilson
2013-07-18 21:59 ` Daniel Vetter
2013-07-12 14:59 Chris Wilson
2013-07-12 14:02 Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130712175655.GE15384@bwidawsk.net \
--to=ben@bwidawsk.net \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox