From: Daniel Vetter <daniel@ffwll.ch>
To: Chia-I Wu <olvaffe@gmail.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH libdrm] intel: silence valgrind warnings for unsynchronized maps
Date: Tue, 16 Jul 2013 15:24:29 +0200 [thread overview]
Message-ID: <20130716132429.GV5784@phenom.ffwll.local> (raw)
In-Reply-To: <1373424599-8583-1-git-send-email-olvaffe@gmail.com>
On Wed, Jul 10, 2013 at 10:49:59AM +0800, Chia-I Wu wrote:
> Mark the address ranges as accessible with VALGRIND_MAKE_MEM_DEFINED.
>
> Signed-off-by: Chia-I Wu <olvaffe@gmail.com>
lgtm. Applied to mater, thanks for the patch.
-Daniel
> ---
> intel/intel_bufmgr_gem.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/intel/intel_bufmgr_gem.c b/intel/intel_bufmgr_gem.c
> index a51e3f3..f98f7a7 100644
> --- a/intel/intel_bufmgr_gem.c
> +++ b/intel/intel_bufmgr_gem.c
> @@ -1322,6 +1322,7 @@ int drm_intel_gem_bo_map_gtt(drm_intel_bo *bo)
> int drm_intel_gem_bo_map_unsynchronized(drm_intel_bo *bo)
> {
> drm_intel_bufmgr_gem *bufmgr_gem = (drm_intel_bufmgr_gem *) bo->bufmgr;
> + drm_intel_bo_gem *bo_gem = (drm_intel_bo_gem *) bo;
> int ret;
>
> /* If the CPU cache isn't coherent with the GTT, then use a
> @@ -1335,7 +1336,13 @@ int drm_intel_gem_bo_map_unsynchronized(drm_intel_bo *bo)
> return drm_intel_gem_bo_map_gtt(bo);
>
> pthread_mutex_lock(&bufmgr_gem->lock);
> +
> ret = map_gtt(bo);
> + if (ret == 0) {
> + drm_intel_gem_bo_mark_mmaps_incoherent(bo);
> + VG(VALGRIND_MAKE_MEM_DEFINED(bo_gem->gtt_virtual, bo->size));
> + }
> +
> pthread_mutex_unlock(&bufmgr_gem->lock);
>
> return ret;
> --
> 1.8.3.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2013-07-16 13:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-10 2:49 [PATCH libdrm] intel: silence valgrind warnings for unsynchronized maps Chia-I Wu
2013-07-16 13:24 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130716132429.GV5784@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=olvaffe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox