Re: [PATCH 0/7] HSW/LPT clocking code additional sequences

[Ben Widawsky <ben@bwidawsk.net>]

On Fri, Jul 12, 2013 at 02:19:35PM -0300, Paulo Zanoni wrote:
> From: Paulo Zanoni <paulo.r.zanoni@intel.com>
> 
> Hi
> 
> On the code that allows Package C8+ we need to disable/reenable the PCH
> reference clocks and also disable/reenable LCPLL. This series implements the
> sequences that are going to be needed. I have local patches that use this code
> and they seem to work (we survive going to C10 and back to C7), and I also sent
> earlier versions of these patches to the mailing list, so open-source code that
> uses these functions already exists on the intel-gfx mailing list. The goal here
> is allow people to review/merge this while the final PC8+ patches are not yet
> 100% reviewer-compliant.
> 
> On the first 3 patches we massage our code so we can reuse it for PC8+ code. On
> patch 4 we extend the current code to also implement one of the sequences
> required by PC8+. On patch 5 we implement the equivalent disable sequence, also
> needed by PC8+. On patch 6 we implement the functions to disable and restore
> LCPLL, and on patch 7 we add some assertions that are going to be used.
> 
> If you want to review patches 1-3 all you need is C experience. For patches 4
> and 5 you need to read the "Display iCLK programming" chapter of BSpec. For
> patches 6 and 7 you need to read "Display sequences for LCPLL disabling" and
> "Display sequences for Package C8".
> 
> Cheers,
> Paulo
> 
> Paulo Zanoni (7):
>   drm/i915: remove SDV support from lpt_pch_init_refclk
>   drm/i915: extract FDI mPHY functions from lpt_init_pch_refclk
>   drm/i915: extract lpt_enable_clkout_dp from lpt_init_pch_refclk
>   drm/i915: extend lpt_enable_clkout_dp
>   drm/i915: disable CLKOUT_DP when it's not needed
>   drm/i915: add functions to disable and restore LCPLL
>   drm/i915: add some assertions to hsw_disable_lcpll
> 
>  drivers/gpu/drm/i915/i915_reg.h      |  17 ++
>  drivers/gpu/drm/i915/intel_display.c | 359 +++++++++++++++++++++++++----------
>  drivers/gpu/drm/i915/intel_drv.h     |   3 +
>  3 files changed, 276 insertions(+), 103 deletions(-)
> 

With the comments addressed in patches 1-5, they are:
Reviewed-by: Ben Widawsky <ben@bwidawsk.net>

I'll wait for feedback before slapping tags on 6 & 7.

-- 
Ben Widawsky, Intel Open Source Technology Center