From: Daniel Vetter <daniel@ffwll.ch>
To: Jani Nikula <jani.nikula@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: do not disable backlight on vgaswitcheroo switch off
Date: Wed, 7 Aug 2013 09:52:22 +0200 [thread overview]
Message-ID: <20130807075222.GR22035@phenom.ffwll.local> (raw)
In-Reply-To: <87y58eyq1x.fsf@intel.com>
On Wed, Aug 07, 2013 at 09:26:34AM +0300, Jani Nikula wrote:
> On Thu, 25 Jul 2013, Jani Nikula <jani.nikula@intel.com> wrote:
> > On muxed systems, the other vgaswitcheroo client may depend on i915 to
> > handle the backlight. We began switching off the backlight since
> >
> > commit a261b246ebd552fd5d5a8ed84cc931bb821c427f
> > Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Date: Thu Jul 26 19:21:47 2012 +0200
> >
> > drm/i915: disable all crtcs at suspend time
> >
> > breaking backlight on discreet graphics in (some) muxed systems.
> >
> > Keep the backlight on when the state is changed through vgaswitcheroo.
> >
> > Note: The alternative would be to add a quirk table to achieve the same
> > based on system identifiers, but AFAICS it would asymptotically approach
> > effectively the same as this patch as more IDs are added, but with the
> > maintenance burden of the quirk table.
> >
> > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=55311
>
> Tested-by: Fede <fedevx@yahoo.com>
> Tested-by: Aximab <laurent.debian@gmail.com>
>
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=59785
>
> Tested-by: sfievet <sebastien.fievet@free.fr>
Picked up for -fixes (with a cc: stable), thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2013-08-07 7:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-25 11:31 [PATCH] drm/i915: do not disable backlight on vgaswitcheroo switch off Jani Nikula
2013-08-07 6:26 ` Jani Nikula
2013-08-07 7:52 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130807075222.GR22035@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox