Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
	Stuart Abercrombie <sabercrombie@chromium.org>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] Lower threshold for pixel doubling.
Date: Fri, 16 Aug 2013 14:15:15 +0200	[thread overview]
Message-ID: <20130816121515.GH776@phenom.ffwll.local> (raw)
In-Reply-To: <20130816082049.GA4761@nuc-i3427.alporthouse.com>

On Fri, Aug 16, 2013 at 09:20:49AM +0100, Chris Wilson wrote:
> On Mon, May 20, 2013 at 11:15:08AM -0700, Stuart Abercrombie wrote:
> > 90% of core speed (=180MHz dot clock) is too high for 2048x1280 to get
> > pixel doubling on Pineview, which it needs to avoid underruns, so
> > lower this to 85%.
> > 
> > Signed-off-by: Stuart Abercrombie <sabercrombie@chromium.org>
> 
> I've not found any rationale in the gen3 bspec describing what the upper
> limit on usuable bw is. Nothing to support the old value nor the new, so
> 
> Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
> 
> And quick before Daniel converts the double-wide tracking to
> pipe_config...

Erhm, we've already fixed this for real in

commit 257a7ffcfaf68718c963db6e9978d1f4f647986b
Author: Daniel Vetter <daniel.vetter@ffwll.ch>
Date:   Fri Jul 26 08:35:42 2013 +0200

    drm/i915: fix pnv display core clock readout out

and the fact that the above mentioned mode with a pixelclock of 167MHz is
right at the display core clock of 166MHz (per spec) suggests that even
the 10% margin we currently have is massive overkill.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

      reply	other threads:[~2013-08-16 12:15 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-20 18:15 [PATCH] Lower threshold for pixel doubling Stuart Abercrombie
2013-05-28 17:39 ` Stuart Abercrombie
2013-05-29 15:22   ` Daniel Vetter
2013-05-29 16:22     ` Stuart Abercrombie
2013-06-21 22:52       ` Stuart Abercrombie
2013-06-24  6:59         ` Daniel Vetter
2013-06-24 23:28           ` Stuart Abercrombie
2013-07-08 18:52             ` Stuart Abercrombie
2013-07-13  0:29               ` Stuart Abercrombie
2013-07-26  6:01             ` Daniel Vetter
2013-07-26  6:19               ` Stéphane Marchesin
2013-08-16  8:20 ` Chris Wilson
2013-08-16 12:15   ` Daniel Vetter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130816121515.GH776@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=sabercrombie@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox