From: Daniel Vetter <daniel@ffwll.ch>
To: Paulo Zanoni <przanoni@gmail.com>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: ivb: fix typo in dp voltage swing reg val
Date: Fri, 23 Aug 2013 22:10:49 +0200 [thread overview]
Message-ID: <20130823201049.GW26909@phenom.ffwll.local> (raw)
In-Reply-To: <20130823200127.GV26909@phenom.ffwll.local>
On Fri, Aug 23, 2013 at 10:01:27PM +0200, Daniel Vetter wrote:
> On Fri, Aug 23, 2013 at 04:01:17PM -0300, Paulo Zanoni wrote:
> > 2013/8/23 Imre Deak <imre.deak@intel.com>:
> > > Fix the typo introduced in
> > >
> > > commit 1a2eb4604b85c5efb343da8a4dcf41288fcfca85
> > > Author: Keith Packard <keithp@keithp.com>
> > > Date: Wed Nov 16 16:26:07 2011 -0800
> > >
> > > drm/i915: Hook up Ivybridge eDP
> > >
> > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=64880
> > > Tested-by: Jeremy Moles <cubicool@gmail.com>
> > > Signed-off-by: Imre Deak <imre.deak@intel.com>
> >
> > Nice catch!
> >
> > Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
>
> Queued for -next, thanks for the patch.
Ok, dropped again since Paulo told me on irc that we fail link training
without this and so this is a black screen fix and so should go to -fixes
with cc: stable.
Grumpy maintainer note: Stuff like this _really_ must be part of the
commit message. A headline of "fix typo in ..." plus no mention of any
further impact than the fixed type for a black screen bug in the commit
message is seriously misleading.
Also this should imo be caught in review (since Paulo obviously knew
what's going on).
Please resend.
Thanks, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2013-08-23 20:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 18:47 [PATCH] drm/i915: ivb: fix typo in dp voltage swing reg val Imre Deak
2013-08-23 19:01 ` Paulo Zanoni
2013-08-23 20:01 ` Daniel Vetter
2013-08-23 20:10 ` Daniel Vetter [this message]
2013-08-23 20:50 ` [PATCH v2] " Imre Deak
2013-08-23 21:02 ` [Intel-gfx] " Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130823201049.GW26909@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=przanoni@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox