From: Daniel Vetter <daniel@ffwll.ch>
To: Ben Widawsky <ben@bwidawsk.net>
Cc: intel-gfx@lists.freedesktop.org,
Ben Widawsky <benjamin.widawsky@intel.com>
Subject: Re: [PATCH] drm/i915: Restore the preliminary HW check.
Date: Thu, 29 Aug 2013 21:13:52 +0200 [thread overview]
Message-ID: <20130829191352.GG5606@phenom.ffwll.local> (raw)
In-Reply-To: <20130829163513.GB4234@bwidawsk.net>
On Thu, Aug 29, 2013 at 09:35:14AM -0700, Ben Widawsky wrote:
> On Fri, Aug 23, 2013 at 04:33:58PM -0700, Jesse Barnes wrote:
> > On Fri, 23 Aug 2013 16:00:07 -0700
> > Ben Widawsky <benjamin.widawsky@intel.com> wrote:
> >
> > > We still maintain code internally that cares about preliminary support.
> > > Leaving the check here doesn't hurt anyone, and should keep things more
> > > in line.
> > >
> > > This time around, stick the info in the intel_info structure, and also
> > > change the error from DRM_ERROR->DRM_INFO.
> >
> > I hate this param.
> >
> > But this looks like a better way to do it than the ID list we had in
> > pci_probe before.
We've never had a table of pci ids, but a simple check for IS_HASWELL ...
> >
> > Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> >
>
> Daniel, ping. One of my goals is to allow people to easily look at
> source and determine which HW is preliminary, and which isn't.
Queued for -next, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2013-08-29 19:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 23:00 [PATCH] drm/i915: Restore the preliminary HW check Ben Widawsky
2013-08-23 23:33 ` Jesse Barnes
2013-08-29 16:35 ` Ben Widawsky
2013-08-29 19:13 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130829191352.GG5606@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=ben@bwidawsk.net \
--cc=benjamin.widawsky@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox