Re: [PATCH] drm/i915: only report hpd connector status change when it actually changed

[Daniel Vetter <daniel@ffwll.ch>]

On Tue, Sep 17, 2013 at 05:56:08PM +0300, Jani Nikula wrote:
> On Tue, 17 Sep 2013, Daniel Vetter <daniel@ffwll.ch> wrote:
> > On Tue, Sep 17, 2013 at 02:26:34PM +0300, Jani Nikula wrote:
> >> This reduces dmesg noise when there's a glitch on the hpd line, or there
> >> are more than one connectors on the same hpd line and only one of them
> >> changes.
> >> 
> >> While at it, switch to use the friendly status names instead of numbers.
> >> 
> >> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> >> ---
> >>  drivers/gpu/drm/i915/i915_irq.c |   14 ++++++++++----
> >>  1 file changed, 10 insertions(+), 4 deletions(-)
> >> 
> >> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
> >> index 13d26cf..a42f30b 100644
> >> --- a/drivers/gpu/drm/i915/i915_irq.c
> >> +++ b/drivers/gpu/drm/i915/i915_irq.c
> >> @@ -665,7 +665,8 @@ static int i915_get_vblank_timestamp(struct drm_device *dev, int pipe,
> >>  						     crtc);
> >>  }
> >>  
> >> -static int intel_hpd_irq_event(struct drm_device *dev, struct drm_connector *connector)
> >> +static bool intel_hpd_irq_event(struct drm_device *dev,
> >> +				struct drm_connector *connector)
> >
> > You change the return value to a bool here, but no users. Missing
> > follow-up patch?
> 
> Nope, the only call site in i915_hotplug_work_func() already treats it
> as a bool.

Somehow I've thought it started out with a void and you switched to bool.
Thanks for removing my blinders, patch merged ;-)

Cheers, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch