From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
intel-gfx@lists.freedesktop.org, stable@vger.kernel.org
Subject: Re: [Intel-gfx] [PATCH v2 2/2] drm/i915: Don't enable the cursor on a disable pipe
Date: Tue, 17 Sep 2013 19:53:19 +0300 [thread overview]
Message-ID: <20130917165319.GY4531@intel.com> (raw)
In-Reply-To: <20130917162401.GD24051@nuc-i3427.alporthouse.com>
On Tue, Sep 17, 2013 at 05:24:01PM +0100, Chris Wilson wrote:
> On Tue, Sep 17, 2013 at 06:33:44PM +0300, ville.syrjala@linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > On HSW enabling a plane on a disabled pipe may hang the entire system.
> > And there's no good reason for doing it ever, so just don't.
> >
> > v2: Move the crtc active checks to intel_crtc_cursor_{set,move} to
> > avoid confusing people during modeset
>
> But outside of modeset the existing checks are accurate.
There are no existing checks anymore. The crtc->enabled check ended up
as collateral damage in the cursor visibility patches.
--
Ville Syrjälä
Intel OTC
next prev parent reply other threads:[~2013-09-17 16:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-17 15:33 [PATCH 0/2] drm/i915: HSW modeset hang fix v2 ville.syrjala
2013-09-17 15:33 ` [PATCH v2 1/2] drm/i915: do not update cursor in crtc mode set ville.syrjala
2013-09-17 15:33 ` [PATCH v2 2/2] drm/i915: Don't enable the cursor on a disable pipe ville.syrjala
2013-09-17 16:24 ` [Intel-gfx] " Chris Wilson
2013-09-17 16:53 ` Ville Syrjälä [this message]
2013-09-17 20:15 ` Paulo Zanoni
2013-09-17 16:07 ` [PATCH 0/2] drm/i915: HSW modeset hang fix v2 Jani Nikula
2013-09-18 8:01 ` Daniel Vetter
2013-09-17 19:17 ` [Intel-gfx] " Paulo Zanoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130917165319.GY4531@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox