From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/5] drm/i915: use wait_event_timeout when waiting for flip completions
Date: Fri, 27 Sep 2013 14:27:59 -0700 [thread overview]
Message-ID: <20130927142759.3ecf70e9@jbarnes-desktop> (raw)
In-Reply-To: <20130927204539.GD744@nuc-i3427.alporthouse.com>
On Fri, 27 Sep 2013 21:45:39 +0100
Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Fri, Sep 27, 2013 at 12:57:23PM -0700, Jesse Barnes wrote:
> > We're shutting the crtc off and don't want to hang forever.
>
> That scares me ever so slightly, especially ignoring the failure. Do you
> want to reset the display controller if the interrupts die, or just
> report a WARN, or propagate the failure back and make userspace try
> again?
>
> But not taking any action at all is a recipe for a silent disaster. It
> has taken years to get to the point where we can turn off the pipes
> reliably...
Yeah this one is definitely a WIP. I'd like to warn when this happens
and clean things up rather than just timing out and letting disaster
befall us later.
--
Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2013-09-27 21:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-27 19:57 [PATCH 1/5] drm/i915/vlv: reduce GT FIFO error info to a debug message Jesse Barnes
2013-09-27 19:57 ` [PATCH 2/5] drm/i915: use wait_event_timeout when waiting for flip completions Jesse Barnes
2013-09-27 20:45 ` Chris Wilson
2013-09-27 21:27 ` Jesse Barnes [this message]
2013-09-28 9:35 ` Daniel Vetter
2013-09-28 14:58 ` Jesse Barnes
2013-09-27 19:57 ` [PATCH 3/5] drm/i915/vlv: warn on bad VLV PLL divider values Jesse Barnes
2013-09-27 20:05 ` Chris Wilson
2013-09-27 20:11 ` Daniel Vetter
2013-09-27 20:17 ` Jesse Barnes
2013-09-27 19:57 ` [PATCH 4/5] drm/i915/vlv: untangle integrated clock source handling v2 Jesse Barnes
2013-09-27 19:57 ` [PATCH 5/5] drm/i915/vlv: add valleyview_crtc_disable function Jesse Barnes
2013-09-27 20:05 ` Daniel Vetter
-- strict thread matches above, loose matches on Subject: below --
2013-09-28 14:18 [PATCH 2/5] drm/i915: use wait_event_timeout when waiting for flip completions Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130927142759.3ecf70e9@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox