[PATCH] drm/i915: Undo the PIPEA quirk for i845

[PATCH] drm/i915: Undo the PIPEA quirk for i845

[Chris Wilson]

The PIPEA quirk is specifically for the issue with the PIPEB PLL on
830gm being slaved to the PIPEA PLL, and so to use PIPEB requires PIPEA
running. i845 doesn't even have the second PLL or pipe, and enabling
the quirk results in a blank DVO LVDS.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/intel_display.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index d33b42c1c092..54cfd0ab8797 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -10307,8 +10307,7 @@ static struct intel_quirk intel_quirks[] = {
 	/* ThinkPad T60 needs pipe A force quirk (bug #16494) */
 	{ 0x2782, 0x17aa, 0x201a, quirk_pipea_force },
 
-	/* 830/845 need to leave pipe A & dpll A up */
-	{ 0x2562, PCI_ANY_ID, PCI_ANY_ID, quirk_pipea_force },
+	/* 830 needs to leave pipe A & dpll A up */
 	{ 0x3577, PCI_ANY_ID, PCI_ANY_ID, quirk_pipea_force },
 
 	/* Lenovo U160 cannot use SSC on LVDS */
-- 
1.8.4.rc3

Re: [PATCH] drm/i915: Undo the PIPEA quirk for i845

[Daniel Vetter]

On Tue, Oct 08, 2013 at 11:16:59AM +0100, Chris Wilson wrote:
> The PIPEA quirk is specifically for the issue with the PIPEB PLL on
> 830gm being slaved to the PIPEA PLL, and so to use PIPEB requires PIPEA
> running. i845 doesn't even have the second PLL or pipe, and enabling
> the quirk results in a blank DVO LVDS.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

Queued for -next, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch