From: Ben Widawsky <ben@bwidawsk.net>
To: Matt Turner <mattst88@gmail.com>
Cc: Intel GFX <intel-gfx@lists.freedesktop.org>,
Ben Widawsky <benjamin.widawsky@intel.com>
Subject: Re: [PATCH intel-gpu-tools] configure: Don't bail if libdrm_nouveau isn't available.
Date: Thu, 10 Oct 2013 21:00:51 -0700 [thread overview]
Message-ID: <20131011040050.GA1116@bwidawsk.net> (raw)
In-Reply-To: <1381463805-10521-1-git-send-email-mattst88@gmail.com>
On Thu, Oct 10, 2013 at 08:56:45PM -0700, Matt Turner wrote:
> We were seriously *requiring* libdrm_nouveau unless explicitly disabled?
Acked-by: Ben Widawsky <ben@bwidawsk.net>
> ---
> configure.ac | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index f65942f..43740f9 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -92,8 +92,11 @@ AM_CONDITIONAL(BUILD_ASSEMBLER, [test "x$enable_assembler" = xyes])
> # -----------------------------------------------------------------------------
> # for dma-buf tests
> AC_ARG_ENABLE(nouveau, AS_HELP_STRING([--disable-nouveau],
> - [Enable use of nouveau API for prime tests (default: enabled)]),
> - [NOUVEAU=$enableval], [NOUVEAU=yes])
> + [Enable use of nouveau API for prime tests (default: auto)]),
> + [NOUVEAU=$enableval], [NOUVEAU=auto])
> +if test "x$NOUVEAU" = xauto; then
> + PKG_CHECK_EXISTS([libdrm_nouveau >= 2.4.33], [NOUVEAU=yes], [NOUVEAU=no])
> +fi
> if test "x$NOUVEAU" = xyes; then
> PKG_CHECK_MODULES(DRM_NOUVEAU, [libdrm_nouveau >= 2.4.33])
> AC_DEFINE(HAVE_NOUVEAU, 1, [Have nouveau support])
> --
> 1.8.3.2
>
--
Ben Widawsky, Intel Open Source Technology Center
next prev parent reply other threads:[~2013-10-11 4:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-11 3:56 [PATCH intel-gpu-tools] configure: Don't bail if libdrm_nouveau isn't available Matt Turner
2013-10-11 4:00 ` Ben Widawsky [this message]
2013-10-11 7:40 ` Daniel Vetter
2013-10-11 19:51 ` Matt Turner
2013-10-11 21:24 ` Daniel Vetter
2013-10-11 21:29 ` Matt Turner
2013-10-11 22:51 ` Chad Versace
2013-10-11 22:52 ` Chad Versace
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131011040050.GA1116@bwidawsk.net \
--to=ben@bwidawsk.net \
--cc=benjamin.widawsky@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mattst88@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox