public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Chad Versace <chad.versace@linux.intel.com>
To: Matt Turner <mattst88@gmail.com>
Cc: Intel GFX <intel-gfx@lists.freedesktop.org>,
	Ben Widawsky <ben@bwidawsk.net>,
	Ben Widawsky <benjamin.widawsky@intel.com>
Subject: Re: [PATCH intel-gpu-tools] configure: Don't bail if libdrm_nouveau isn't available.
Date: Fri, 11 Oct 2013 15:51:58 -0700	[thread overview]
Message-ID: <5258810E.7080207@linux.intel.com> (raw)
In-Reply-To: <CAEdQ38ForTFVyM59FegbLWhecB9uNBjA4_kQtz1+1zObVeHvKw@mail.gmail.com>

On 10/11/2013 02:29 PM, Matt Turner wrote:
> On Fri, Oct 11, 2013 at 2:24 PM, Daniel Vetter <daniel@ffwll.ch> wrote:
>> On Fri, Oct 11, 2013 at 12:51:34PM -0700, Matt Turner wrote:
>>> On Fri, Oct 11, 2013 at 12:40 AM, Daniel Vetter <daniel@ffwll.ch> wrote:
>>>> On Fri, Oct 11, 2013 at 5:56 AM, Matt Turner <mattst88@gmail.com> wrote:
>>>>> We were seriously *requiring* libdrm_nouveau unless explicitly disabled?
>>>>
>>>> I've had a bit of hilarious fail with optional testcases that
>>>> automatically get disabled when depencies aren't around. Hence why
>>>> they're all required by default with the optional switch to disable
>>>> them.
>>>
>>> You've had this problem in general, or with nouveau?
>>
>> In general.
>
> So I think what I'm saying is that the nouveau support in
> intel-gpu-tools isn't the project's primary purpose, so we should
> allow it to build without nouveau support if you don't have nouveau
> installed. If you don't have nouveau installed, you're not making a
> mistake by not building intel-gpu-tools without support. And if you
> have nouveau installed, you still get nouveau support.

I completely agree with Matt.

If the system doesn't already have nouveau installed, then it there is very
low likelihood that it makes any sense to install nouveau onto that system.
It very likely does not have NVidia hardware at all. So why require it?
Let's just autodetect it and behave sanely.

Requiring libdrm_nouveau is a nuisance for developers working on platforms
where libdrm doesn't get built with NVidia support.

  reply	other threads:[~2013-10-11 22:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-11  3:56 [PATCH intel-gpu-tools] configure: Don't bail if libdrm_nouveau isn't available Matt Turner
2013-10-11  4:00 ` Ben Widawsky
2013-10-11  7:40 ` Daniel Vetter
2013-10-11 19:51   ` Matt Turner
2013-10-11 21:24     ` Daniel Vetter
2013-10-11 21:29       ` Matt Turner
2013-10-11 22:51         ` Chad Versace [this message]
2013-10-11 22:52           ` Chad Versace

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5258810E.7080207@linux.intel.com \
    --to=chad.versace@linux.intel.com \
    --cc=ben@bwidawsk.net \
    --cc=benjamin.widawsky@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=mattst88@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox