Re: [PATCH 1/2] drm/i915: make backlight functions take a connector v3

[Jesse Barnes <jbarnes@virtuousgeek.org>]

On Fri, 11 Oct 2013 14:34:35 -0700
Jesse Barnes <jbarnes@virtuousgeek.org> wrote:

> > Ideas:
> > - Make sure all lvds/edp connectors are enabled and bash on all backlight
> >   interfaces (with igt_fork it's easy to do that concurrently).
> > - Race the above with output changes: dpms on/off and changing the crtc
> >   around.
> > - Race the above with system suspend for bonus points (can be completely
> >   stitched together from igt helpers).  
> 
> Sorry can't volunteer for that now, but those sound like good tests to
> write.

To clarify per our discussion on IRC.  I'll try to make some time next
week to add some tests for this.  We'll need them for the further
intel_panel.c work (getting rid of all the bogus save/restore of the
bits sprinkled about now that we don't do display reset).

But I don't want this fix (once I fix the locking) blocked on
those tests, since they'll probably take me a few days and people are
already using the original version, which is missing the locks for the
backlight class and ASLE call sites.

Thanks,
-- 
Jesse Barnes, Intel Open Source Technology Center