From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Ben Widawsky <benjamin.widawsky@intel.com>,
Intel GFX <intel-gfx@lists.freedesktop.org>,
Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH] drm/i915: Print RC6 info less often
Date: Mon, 21 Oct 2013 10:05:09 +0200 [thread overview]
Message-ID: <20131021080508.GE4830@phenom.ffwll.local> (raw)
In-Reply-To: <20131019115312.GB23391@nuc-i3427.alporthouse.com>
On Sat, Oct 19, 2013 at 12:53:12PM +0100, Chris Wilson wrote:
> On Fri, Oct 18, 2013 at 12:32:07PM -0700, Ben Widawsky wrote:
> > Since we use intel_enable_rc6() now for more than just when we're
> > enabling RC6, we'll see this message many times, and it is just
> > confusing.
>
> I agree. Ok, had to double check that i915.i915_enable_rc6 was not
> writable at runtime, so it looks like the defaults are fixed and so it
> is not possible for intel_enable_rc6() to return different values over
> its lifetime.
>
> > As an example, calc_residency calls this function whenever poked via
> > sysfs. This leaves the impression in dmesg that we're constantly
> > re-enabling RC6.
> >
> > While at it, move the defines and description from drv.h to intel_pm.c,
> > since these are only ever used in that code.
> >
> > Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Queued for -next, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2013-10-21 8:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-18 19:32 [PATCH] drm/i915: Print RC6 info less often Ben Widawsky
2013-10-19 11:53 ` Chris Wilson
2013-10-21 8:05 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131021080508.GE4830@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=ben@bwidawsk.net \
--cc=benjamin.widawsky@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox