From: Daniel Vetter <daniel@ffwll.ch>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/vlv: Fix typo in the DPIO register define.
Date: Thu, 31 Oct 2013 13:05:09 +0100 [thread overview]
Message-ID: <20131031120509.GI4167@phenom.ffwll.local> (raw)
In-Reply-To: <20131031114631.GA13047@intel.com>
On Thu, Oct 31, 2013 at 01:46:31PM +0200, Ville Syrjälä wrote:
> On Wed, Oct 30, 2013 at 10:05:19AM +0800, Chon Ming Lee wrote:
> > Incorrect definition DPIO_TX3_SWING_CTL4.
> >
> > Signed-off-by: Chon Ming Lee <chon.ming.lee@intel.com>
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Queued for -next, thanks for the patch.
> Based on the specs, the typo meant that HDMI B ended up using
> "incorrect" de-emphasis for the TMDS data lanes.
I've added this explanation to the commit message to describe the impact a
bit better. Next time around please elaborate a bit more about the impact
of a change so other people have an idea how important a patch is or
whether it might help for a given issue they have.
Thanks, Daniel
>
> > ---
> > drivers/gpu/drm/i915/i915_reg.h | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> > index 6799d53..f7ecad2 100644
> > --- a/drivers/gpu/drm/i915/i915_reg.h
> > +++ b/drivers/gpu/drm/i915/i915_reg.h
> > @@ -444,7 +444,7 @@
> >
> > #define _DPIO_TX3_SWING_CTL4_A 0x690
> > #define _DPIO_TX3_SWING_CTL4_B 0x2a90
> > -#define DPIO_TX3_SWING_CTL4(pipe) _PIPE(pipe, _DPIO_TX_SWING_CTL4_A, \
> > +#define DPIO_TX3_SWING_CTL4(pipe) _PIPE(pipe, _DPIO_TX3_SWING_CTL4_A, \
> > _DPIO_TX3_SWING_CTL4_B)
> >
> > /*
> > --
> > 1.7.7.6
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
> --
> Ville Syrjälä
> Intel OTC
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2013-10-31 12:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-30 2:05 [PATCH] drm/i915/vlv: Fix typo in the DPIO register define Chon Ming Lee
2013-10-31 11:46 ` Ville Syrjälä
2013-10-31 12:05 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131031120509.GI4167@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox