Re: [PATCH 0/5] igt test naming conventions

[Daniel Vetter <daniel@ffwll.ch>]

On Sat, Nov 02, 2013 at 01:04:31PM +0100, Daniel Vetter wrote:
> Hi all,
> 
> Spurred by the ongoing discussions about improving our tests I've started to
> document some of the naming patterns a bit. I've also added a few new ones and
> renamed a bunch of tests.
> 
> The idea is that developers can use this patterns to construct add-hoc test
> groups with piglit's -t/-x options. I hope this here is a good start, but we
> certainly need to refine the patterns and test names over time.
> 
> To ensure that we have sufficient coherency I propose the following rules:
> - If you add a large pile of new tests please document any new tests patterns in
>   tests/NAMING-CONVENTIONS.
> - Any patches that are relevant for the test naming conventions must be posted
>   to intel-gfx to keep everyone in the loop.
> 
> Comments and ideas both on the patches and process highly welcome.

Ok I've pushed this after a bit of irc chatting. Please have a look at the
naming convention when writing new tests (or subtests). And if you see
some room to clarify things, patches (to intel-gfx) highly welcome.
-Daniel

> 
> Cheeers, Daniel
> 
> Daniel Vetter (5):
>   tests: Start to document naming conventions
>   tests: estbalish drv_ prefix
>   tests: establish pm_ prefix
>   tests: Use kms_ prefix a bit more
>   tests: establish core_ prefix
> 
>  README                      |   3 +
>  tests/.gitignore            |  16 +-
>  tests/Makefile.am           |  26 +-
>  tests/NAMING-CONVENTION     |  63 ++++
>  tests/ZZ_hangman            |  70 ----
>  tests/ZZ_missed_irq         |  72 ----
>  tests/core_getclient.c      |  61 ++++
>  tests/core_getstats.c       |  50 +++
>  tests/core_getversion.c     |  49 +++
>  tests/debugfs_pipe_crc.c    | 262 --------------
>  tests/debugfs_reader        |   9 -
>  tests/drv_debugfs_reader    |   9 +
>  tests/drv_hangman           |  70 ++++
>  tests/drv_missed_irq_hang   |  72 ++++
>  tests/drv_module_reload     |  50 +++
>  tests/drv_suspend.c         | 171 +++++++++
>  tests/gem_suspend.c         | 171 ---------
>  tests/getclient.c           |  61 ----
>  tests/getstats.c            |  50 ---
>  tests/getversion.c          |  49 ---
>  tests/kms_pipe_crc_basic.c  | 262 ++++++++++++++
>  tests/kms_sysfs_edid_timing |  25 ++
>  tests/module_reload         |  50 ---
>  tests/pc8.c                 | 822 --------------------------------------------
>  tests/pm_pc8.c              | 822 ++++++++++++++++++++++++++++++++++++++++++++
>  tests/pm_rc6_residency.c    | 121 +++++++
>  tests/pm_rps.c              | 194 +++++++++++
>  tests/sysfs_edid_timing     |  25 --
>  tests/sysfs_rc6_residency.c | 121 -------
>  tests/sysfs_rps.c           | 194 -----------
>  30 files changed, 2043 insertions(+), 1977 deletions(-)
>  create mode 100644 tests/NAMING-CONVENTION
>  delete mode 100755 tests/ZZ_hangman
>  delete mode 100755 tests/ZZ_missed_irq
>  create mode 100644 tests/core_getclient.c
>  create mode 100644 tests/core_getstats.c
>  create mode 100644 tests/core_getversion.c
>  delete mode 100644 tests/debugfs_pipe_crc.c
>  delete mode 100755 tests/debugfs_reader
>  create mode 100755 tests/drv_debugfs_reader
>  create mode 100755 tests/drv_hangman
>  create mode 100755 tests/drv_missed_irq_hang
>  create mode 100755 tests/drv_module_reload
>  create mode 100644 tests/drv_suspend.c
>  delete mode 100644 tests/gem_suspend.c
>  delete mode 100644 tests/getclient.c
>  delete mode 100644 tests/getstats.c
>  delete mode 100644 tests/getversion.c
>  create mode 100644 tests/kms_pipe_crc_basic.c
>  create mode 100755 tests/kms_sysfs_edid_timing
>  delete mode 100755 tests/module_reload
>  delete mode 100644 tests/pc8.c
>  create mode 100644 tests/pm_pc8.c
>  create mode 100644 tests/pm_rc6_residency.c
>  create mode 100644 tests/pm_rps.c
>  delete mode 100755 tests/sysfs_edid_timing
>  delete mode 100644 tests/sysfs_rc6_residency.c
>  delete mode 100644 tests/sysfs_rps.c
> 
> -- 
> 1.8.4.rc3
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch